Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph generation #401

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

jwallace42
Copy link
Contributor

This PR adds a tutorial for graph generation. This graph is designed to be consumed by the nav2_route.

The sql script for id association can be found here.

I would suggest creating a ROS Planning repository that holds the QGIS data. This will allow us to make quick changes to current graphs and store plugins that automate the graph generation.

https://github.com/jwallace42/qgis-maps/tree/main

tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/graph_generation.rst Outdated Show resolved Hide resolved
@SteveMacenski
Copy link
Member

Is there a reason not to have the sql script in the nav2_route package?

@jwallace42
Copy link
Contributor Author

Is there a reason not to have the sql script in the nav2_route package?

We need the QGIS files to easily modify the graph. I would suggest that that script stays with the QGIS graphs repo https://github.com/jwallace42/qgis-maps.

@jwallace42
Copy link
Contributor Author

@SteveMacenski if you get a chance to review this week that would be great. Otherwise, I might forget what I did :).

@SteveMacenski
Copy link
Member

@jwallace42 there are still many unresponded to comments in the previous reviews

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much, much improved!!

tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
Tutorial Steps
==============

1- Open QGIS and create a new project by selecting `Project->New`. Save your project by selecting, `Project -> Save As`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mention this before since its a final cleanup thing but we're at this point now: For all the numbered steps, make them subsections. If you use the ----- header type, then it'll fall under the Tutorial Steps section but be more easily pronounced.

So like

1- Create New QGIS Project
----------------------------------

or

2- Setup Coordinate System
-------------------------------------

tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved

|

.. image:: images/route_graph_generation/nodes.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this one a bit larger, I can't see the buttons you have highlighted in the render

|

.. image:: images/route_graph_generation/edges.png
:height: 250px
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this also a little bigger for the buttons to be able to see

tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
tutorials/docs/route_graph_generation.rst Outdated Show resolved Hide resolved
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - just waiting for server to be released to merge. You can remove this from your queue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants