Add note on multirobot refactor to migration guide #609
+101
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <[email protected]>
7 tasks
SteveMacenski
requested changes
Nov 20, 2024
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
|
One more thing and this should be done https://docs.nav2.org/tuning/index.html --> remove the |
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
force-pushed
the
luca/multirobot_migration
branch
from
315efce
to
662efa0
Compare
Signed-off-by: Luca Della Vedova <[email protected]>
SteveMacenski
approved these changes
Nov 25, 2024
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
|
I fixed some formatting for you, LGTM |
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
|
It shows that I only wrote markdown in my life 😅, noticed that the highlighting of snippets wasn't working because it's supposed to be double backtick so fixed that in 3cc1e2e |
Signed-off-by: Luca Della Vedova <[email protected]>
SteveMacenski
requested changes
Nov 27, 2024
| @@ -29,6 +29,14 @@ This costmap layer implements a plugin that processes sonar, IR, or other 1-D se | |||
| Description | |||
| Range topics to subscribe to. | |||
|
|
|||
| Relative topics will be relative to the node's parent namespace. | |||
There was a problem hiding this comment.
Missed the entry for map_topic now 😉
Sorry to be a stickler about docs, I know its frustrating :(
There was a problem hiding this comment.
Apologies not sure I follow, I thought map_topic is only a parameter in static_layer? Why is this comment on range_sensor_layer?
lucadv@noble:~/ionic_ws/src/nav2/navigation2/nav2_costmap_2d/plugins$ grep -r . -e map_topic
./static_layer.cpp: map_topic_.c_str(),
./static_layer.cpp: map_topic_, map_qos,
./static_layer.cpp: map_topic_ + "_updates",
./static_layer.cpp: declareParameter("map_topic", rclcpp::ParameterValue("map"));
./static_layer.cpp: node->get_parameter(name_ + "." + "map_topic", map_topic_);
./static_layer.cpp: map_topic_ = joinWithParentNamespace(map_topic_);
./static_layer.cpp: param_name == name_ + "." + "map_topic" ||
|
Otherwise, I can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add migration for PR ros-navigation/navigation2#4715