Skip to content

Conversation

stevedanomodolor
Copy link
Contributor

No description provided.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unclear on the GZ bridge changes. Are all (or any?) of them necessary? They seem to be doing the same thing in most cases, except for TF and a couple others having the GZ topic with a forward slash. I don't think that's necessary however and may actually break multirobot namespacing

@stevedanomodolor
Copy link
Contributor Author

There are not necessary, just took advantage to follow the same structure as https://github.com/ros-navigation/nav2_minimal_turtlebot_simulation/blob/main/nav2_minimal_tb4_sim/configs/tb4_bridge.yaml#L1.

About the multirobot namespace, I am not sure, Should I remove the slashes then?

@SteveMacenski
Copy link
Member

Yeah revert these if they're not necessary. The TB3 supports namespacing right now but the TB4 doesnt

Signed-off-by: Stevedan Omodolor <[email protected]>
Signed-off-by: Stevedan Omodolor <[email protected]>
@stevedanomodolor stevedanomodolor force-pushed the feat/update_gps_tutorial branch from a018b03 to b8cf6c9 Compare July 7, 2025 20:27
@stevedanomodolor
Copy link
Contributor Author

Yeah revert these if they're not necessary. The TB3 supports namespacing right now but the TB4 doesnt

I would leave the changes to the other file becuase there are comments that might be usefull later, specifically the gps std_dev comment.

@stevedanomodolor
Copy link
Contributor Author

Yeah revert these if they're not necessary. The TB3 supports namespacing right now but the TB4 doesnt

made the changes

@SteveMacenski SteveMacenski merged commit 05c76c5 into ros-navigation:main Jul 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants