Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cross-platform CI with conda packages #1600

Draft
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Mar 31, 2021

Description

Hi, the intent of this PR is twofold:

  • setup cross-platform CI for RViz: this compiles against the cross-platform ROS packages from the RoboStack project (macOS, Windows and Linux)
  • upstream changes that we had to make in the RoboStack project to be able to compile & run rviz on all three platforms

I (myself) have to go through the patches that we added and figure out how we can upstream them (and I will note that in it's current state they are not ready to be upstreamed -- that's why this is a draft PR).

Checklist

  • If you are addressing rendering issues, please provide:
    • Images of both, broken and fixed renderings.
    • Source code to reproduce the issue, e.g. a YAML or rosbag file with a MarkerArray msg.
  • If you are changing GUI, please include screenshots showing how things looked before and after.
  • Choose the proper target branch: latest release branch, for non-ABI-breaking changes, future release branch otherwise.
    Due to the lack of active maintainers, we cannot provide support for older release branches anymore.
  • Did you change how RViz works? Added new functionality? Do not forget to update the tutorials and/or documentation on the ROS wiki
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers of RViz. Refer to the RViz Wiki for reviewing guidelines.

resolution 96
}

# Ogre >= 1.10 has changed the format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think it's actually Ogre > 1.10 that has changed format, not >= 1.10. As we use Ogre 1.10 in RoboStack, this causes issues. But to be confirmed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you end up with 1.10? You could solve this by updating to 1.12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does rviz work with 1.12? If yes, we could totally attempt a build!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noetic-devel does, yes, I tried getting it set as the default for noetic actually but gazebo had already released their last ever release and have some issues with it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we also have gazebo on conda forge and it would be better if rviz and gazebo are side by side installable, so it's the same problem. We could build a variant with updated ogre though

@@ -34,6 +34,7 @@
#include <OgreRectangle2D.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the changes that are from #1532 and discuss them there instead.

@Tobias-Fischer
Copy link
Contributor

The cross-platform CI in action can be seen here

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/robostack-using-ros-alongside-the-conda-and-jupyter-ecosystems-on-any-linux-macos-windows-arm/20250/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants