Skip to content

Fix revolute joints with infinite limits not working in SDF#106

Open
Amronos wants to merge 1 commit intoros:ros2from
Amronos:fix-inf-revolute-joints
Open

Fix revolute joints with infinite limits not working in SDF#106
Amronos wants to merge 1 commit intoros:ros2from
Amronos:fix-inf-revolute-joints

Conversation

@Amronos
Copy link
Copy Markdown

@Amronos Amronos commented Dec 9, 2024

Fixes #105.

@Amronos Amronos force-pushed the fix-inf-revolute-joints branch from ece7567 to 1446c83 Compare December 9, 2024 15:09
@Amronos
Copy link
Copy Markdown
Author

Amronos commented Dec 9, 2024

I don't really know why the jammy checks are failing, but the noble ones are probably failing because of an error in test_parsing.py or test_flake8.py.
The reasons for the checks failing don't look related to this PR.

@clalancette
Copy link
Copy Markdown
Collaborator

Thanks, #107 should fix the flake8 errors here.

@clalancette
Copy link
Copy Markdown
Collaborator

If you rebase onto the latest code on ros2, the flake8 errors should be fixed.

@Amronos
Copy link
Copy Markdown
Author

Amronos commented Dec 10, 2024

Thanks, should be ready to merge now.

@Amronos
Copy link
Copy Markdown
Author

Amronos commented Dec 20, 2024

@clalancette Any updates on this PR?

@Amronos
Copy link
Copy Markdown
Author

Amronos commented Feb 8, 2025

@clalancette @sloretz friendly ping :-)

@Amronos Amronos force-pushed the fix-inf-revolute-joints branch from abd8039 to 8119898 Compare January 17, 2026 09:42
Signed-off-by: Aarav Gupta <aarav@spikonado.com>
@Amronos Amronos force-pushed the fix-inf-revolute-joints branch from 8119898 to 93df80a Compare January 21, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

joint_state_publisher_gui gives errors on using revolute joints with inf limits in SDF

2 participants