-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable /opt/ros prefix for ROS 2 #1149
base: kirkstone-next
Are you sure you want to change the base?
Conversation
Signed-off-by: Jiaxing Shi <[email protected]>
Since ROS 2 binaries are installed to /opt, the copy operations are no longer needed. Signed-off-by: Jiaxing Shi <[email protected]>
@jiaxshi Thank you very much for submitting this. I have done a quick visual review and everything looks pretty complete and I was impressed by your attention to the details on what would be affected. The only question that I had was in ros_ament_python.bbclass in regards to PYTHON_SITEPACKAGES_DIR. I tried to add a comment on that line directly in the review. I will try running some build tests to test it out. |
Hi Rob, |
Thanks again for contributing this! I am genuinely excited about people being able to follow the instructions in the documentation and tutorials exactly with a good chance of success. Based on our conversation, I decided to first apply it on rolling and jazzy. I intend to do a hard cutover to using /opt/ros/ as the prefix as it shouldn't affect any existing work. I was able to successfully go through the basic image sanity test instructions on the wiki. This was using scarthgap+jazzy on a Raspberry Pi 4. Next I intend to use it as I complete the GUI work for kirkstone+humble. That should help test it sufficiently to ensure that it can be safely merged into kirkstone+humble. From there I will try to push it across all the supported combinations. |
I truly appreciate your gratitude and am glad to have been of assistance. Please feel free to reach out if there’s anything more I can help with. |
I have merged the changes into the master and scarthgap branches. I still have kirkstone (LTS) left to do once I have done some more extensive testing. |
Hi I tried to build octomap with scarthgap branch and got error in installing packages.
When I had tried to build it with kirkstone branch, there is no issue for me. I investigated this issue and found a clue. I think this erros was from changing CMAKE_INSTALL_PREFIX to ros_prefix. octomap had installed to previous CMAKE_INSTALL_PREFIX. I think that some recipes using following conditions at the same time would be affected.
and
I could avoid this error with BR, |
Hi @mark-bchoi
in meta-ros2-humble/recipes-bbappends/octomap/octomap_1.9.8-1.bbappend |
Hi @jiaxshi I tested it as your recommendation and got the same error I gone through. I add entire error log here.
|
Hi @mark-bchoi
|
Hi @jiaxshi I checked your solution work properly now. Thanks. BR, |
The implementation is based on cmake and python compilation configurations.
#1079