Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the right branch on geometry_tutorials #41871

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Use the right branch on geometry_tutorials #41871

merged 2 commits into from
Jul 5, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 28, 2024

Related with this PR ros/ros_tutorials#169

I created turtlesim_msgs which is not backportable to other distros. This PR use the right branch

@ahcorde
Use the right branch on geometry_tutorials
258bdba 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from clalancette June 28, 2024 10:50
@ahcorde ahcorde self-assigned this Jun 28, 2024
@github-actions github-actions bot added humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution labels Jun 28, 2024
clalancette
clalancette reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to suggest that since we are renaming branches on geometry_tutorials, we also switch the Rolling branch to rolling. It is just more consistent with what we do in the core.

@ahcorde
Update rolling branch too
88781bc 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Jul 1, 2024
@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 1, 2024

I created the branch rolling and update rosdistro.

What we should do with the ros2 branch in the geometry_tutorials repository?

@ahcorde ahcorde requested a review from clalancette July 1, 2024 11:39
@clalancette
Copy link
Contributor

What we should do with the ros2 branch in the geometry_tutorials repository?

I would just leave it as-is. It is historical, and used in older distributions.

clalancette
clalancette approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but we need to hold off on merging it so we don't break the Jazzy sync freeze.

@clalancette clalancette added the held for sync Issue/PR has been held because the distribution is in a sync hold label Jul 1, 2024
@marcoag marcoag merged commit 0169b52 into master Jul 5, 2024
4 checks passed
@marcoag marcoag deleted the ahcorde/geometry_tutorials/branches branch July 5, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich nuclearsandwich is a code owner

Assignees

@ahcorde ahcorde

Labels
held for sync Issue/PR has been held because the distribution is in a sync hold humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @clalancette @marcoag