jsk_3rdparty: 2.1.30-1 in 'noetic/distribution.yaml' [bloom]#45685
Closed
k-okada wants to merge 1 commit intoros:masterfrom
Closed
jsk_3rdparty: 2.1.30-1 in 'noetic/distribution.yaml' [bloom]#45685k-okada wants to merge 1 commit intoros:masterfrom
k-okada wants to merge 1 commit intoros:masterfrom
Conversation
github-actions
bot
added
the
noetic
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for sending a pull request to ROS distro!
This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.
ROS Distro Considerations
- ROS Distributions are created using REP-134 Standards Track as a guide.
- Your package name should comply to REP-144 ROS Package Naming
- Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
- Your package must contain an OSI approved license. Your
package.xmlfile must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details. - A publicly available, open source, repository for your ROS package.
- While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
- If you would like, you may join our Discord Server and ask questions in the
#infra-helpchannel.
Package Considerations
Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.
- REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
- Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
- Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
- We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.
Need Help?
Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
sloretz
requested changes
May 12, 2025
Contributor
There was a problem hiding this comment.
Please add LICENSE files to:
./emotion_analyzer
./3rdparty/voicevox
./3rdparty/voice_text
The slic package licencse does not seem to be OSI approved. It's not clear if we can distribute this package on the buildfarm. I will open a separate PR to remove it. edit: removed #45713
- At least one of the following must be present
- Top level license file:
- Per package license files
- License is OSI-approved:
- License correctly listed in package.xmls
- Public source repo:
- Source repository contains ROS packages
- Each package meets REP-144 naming conventions
Package name details
$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
<name>zdepth_image_transport</name>
<name>webrtcvad_ros</name>
<name>switchbot_ros</name>
<name>sesame_ros</name>
<name>rostwitter</name>
<name>rosping</name>
<name>rospatlite</name>
<name>ros_speech_recognition</name>
<name>ros_google_cloud_language</name>
<name>respeaker_ros</name>
<name>pgm_learner</name>
<name>opt_camera</name>
<name>nfc_ros</name>
<name>julius_ros</name>
<name>openni_tracker_jsk_patch</name>
<name>laser_filters_jsk_patch</name>
<name>depth_image_proc_jsk_patch</name>
<name>collada_urdf_jsk_patch</name>
<name>jsk_3rdparty</name>
<name>influxdb_store</name>
<name>google_chat_ros</name>
<name>gdrive_ros</name>
<name>emotion_analyzer</name>
<name>dialogflow_task_executive</name>
<name>chaplus_ros</name>
<name>bayesian_belief_networks</name>
<name>zdepth</name>
<name>voicevox</name>
<name>voice_text</name>
<name>slic</name>
<name>osqp</name>
<name>nlopt</name>
<name>edit: mini_maxwell
<name>lpg_planner</name>
<name>libsiftfast</name>
<name>libcmt</name>
<name>julius</name>
<name>google_cloud_texttospeech</name>
<name>ffha</name>
<name>ff</name>
<name>downward</name>
<name>assimp_devel</name>
<name>aques_talk</name>
License details
$ find . -name "package.xml" -exec grep --color=auto -e "<license[^>]*>" "{}" "+"
./zdepth_image_transport/package.xml: <license>BSD</license>
./webrtcvad_ros/package.xml: <license>BSD</license>
./switchbot_ros/package.xml: <license>BSD</license>
./sesame_ros/package.xml: <license>BSD</license>
./rostwitter/package.xml: <license>Apache</license>
./rosping/package.xml: <license>Boost Software License, Version 1.0</license>
./rospatlite/package.xml: <license>BSD</license>
./ros_speech_recognition/package.xml: <license>BSD</license>
./ros_google_cloud_language/package.xml: <license>BSD</license>
./respeaker_ros/package.xml: <license>Apache</license>
./pgm_learner/package.xml: <license>MIT</license>
./opt_camera/package.xml: <license>BSD</license>
./nfc_ros/package.xml: <license>BSD</license>
./julius_ros/package.xml: <license>BSD</license>
./jsk_ros_patch/openni_tracker_jsk_patch/package.xml: <license>BSD</license>
./jsk_ros_patch/laser_filters_jsk_patch/package.xml: <license>BSD</license>
./jsk_ros_patch/depth_image_proc_jsk_patch/package.xml: <license>BSD</license>
./jsk_ros_patch/collada_urdf_jsk_patch/package.xml: <license>BSD</license>
./jsk_3rdparty/package.xml: <license>BSD</license>
./influxdb_store/package.xml: <license>BSD</license>
./google_chat_ros/package.xml: <license>BSD</license>
./gdrive_ros/package.xml: <license>BSD</license>
./emotion_analyzer/package.xml: <license>BSD</license>
./dialogflow_task_executive/package.xml: <license>BSD</license>
./chaplus_ros/package.xml: <license>BSD</license>
./bayesian_belief_networks/package.xml: <license>Apache License, Version 2.0</license>
./3rdparty/zdepth/package.xml: <license>BSD</license>
./3rdparty/voicevox/package.xml: <license>MIT</license>
./3rdparty/voice_text/package.xml: <license>HOYA License</license>
./3rdparty/slic/package.xml: <license>N/A</license>
./3rdparty/osqp/package.xml: <license>Apache</license>
./3rdparty/nlopt/package.xml: <license>MIT</license>
./3rdparty/mini_maxwell/package.xml: <license>BSD</license>
./3rdparty/lpg_planner/package.xml: <license>GPL</license>
./3rdparty/libsiftfast/package.xml: <license>LGPL</license>
./3rdparty/libcmt/package.xml: <license>BSD</license>
./3rdparty/julius/package.xml: <license>GPL</license>
./3rdparty/google_cloud_texttospeech/package.xml: <license>BSD</license>
./3rdparty/ffha/package.xml: <license>GPL</license>
./3rdparty/ff/package.xml: <license>GPL</license>
./3rdparty/downward/package.xml: <license>GPL</license>
./3rdparty/assimp_devel/package.xml: <license>BSD</license>
./3rdparty/aques_talk/package.xml: <license>BSD</license>
Merged
emersonknapp
requested changes
May 12, 2025
Contributor
emersonknapp
left a comment
emersonknapp
left a comment
There was a problem hiding this comment.
These newly added packages do not appear to have LICENSE files in them, and there isn't a global LICENSE file for the repository.
emotion_analyzer says BSD in package.xml
voicevox says MIT in package.xml
The rosdistro requirements need a LICENSE file for each package (or one at the top of the repository that covers all packages)
emersonknapp
added
the
changes requested
Contributor
|
haha oops sorry @sloretz i didn't even see your review already caught that, i was on autopilot |
Contributor
Author
|
@emersonknapp @sloretz thanks for revew, added licnese file and released new version #45725 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasing version of package(s) in repository
jsk_3rdpartyto2.1.30-1:noetic/distribution.yaml0.11.22.1.28-1aques_talk
assimp_devel
bayesian_belief_networks
chaplus_ros
collada_urdf_jsk_patch
dialogflow_task_executive
downward
emotion_analyzer
ff
ffha
gdrive_ros
google_chat_ros
google_cloud_texttospeech
influxdb_store
jsk_3rdparty
julius
julius_ros
libcmt
libsiftfast
lpg_planner
mini_maxwell
nfc_ros
opt_camera
osqp
pgm_learner
respeaker_ros
ros_google_cloud_language
ros_speech_recognition
rospatlite
rosping
rostwitter
sesame_ros
slic
switchbot_ros
voice_text
voicevox
webrtcvad_ros
zdepth
zdepth_image_transport