-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from tinyxml to tinyxml2 #186
Merged
+377
−366
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9fd9cf6
upgrade from tinyxml to tinyxml2
felixf4xu 06a18de
More cleanups.
clalancette 2f45917
Remove 'using tinyxml2'
clalancette f2a2ce5
Update github actions.
clalancette 2383a0a
Add in FindTinyXML2 for systems that don't have it.
clalancette a68d9a8
Make sure that tinyxml2::tinyxml2 is available in downstream packages
traversaro bef2860
Update urdfdom-config.cmake.in
traversaro a448c63
Replace InsertNewChildElement with GetDocument()->NewElement.
clalancette 713e457
Remove another use of using tinyxml2.
clalancette 2c58e3f
Merge remote-tracking branch 'traversaro/patch-3' into tinyxml2
clalancette b592bbd
Fix generation of CMake config files.
clalancette 0e61d1f
Install the FindTinyXML2.cmake file.
clalancette 23ea44e
Backup and restore the CMAKE_MODULE_PATH.
clalancette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove 'using tinyxml2'
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
commit 2f459176b1c2f127c8eefa487d5dda30912d0af5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just remembered that we had planned some changes to the public API in #178 so that
tinyxml2.h
wouldn't need to be included from this header file. We can address those in a separate pull request, so that this is a cleaner tinyxml -> tinyxml2 replacementThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added an issue for this: #189