Do the pip package dance for colcon as well. #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, only install the colcon packages if they were not installed via an earlier mechanism. We also make sure to only both calling "pip install" if there are any packages to install. Signed-off-by: Chris Lalancette <[email protected]>
|
CI:
|
cottsay
approved these changes
Mar 29, 2024
nuclearsandwich
approved these changes
Mar 29, 2024
|
All right. The warnings here were unrelated to this PR; instead, they are related to ros2/rcl#1135 (which was reverted in ros2/rcl#1142), and a change to qt_dotgraph, which should be fixed by ros-visualization/qt_gui_core#290 . With that in mind, I'm going to go ahead and merge this one in. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, only install the colcon packages if they were not installed via an earlier mechanism.
We also make sure to only both calling "pip install" if there are any packages to install.