Add system package dependency on osrf-pycommon #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intend to drop the `osrf_pycommon` ROS package in favor of using it as a standalone Python library.
nuclearsandwich
approved these changes
Dec 3, 2024
clalancette
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
This is the direction we want to go, so I'm approving.
However, I will point out that the CI that was already run here isn't any "different" than normal CI. That's because we are still building osrf_pycommon during colcon build. My suggestion would be to do another CI run here with a custom ros2.repos where osrf_pycommon is removed, just to make sure it works fine (I expect it will, but it is always worth checking).
At this point, I just wanted to prove that this wasn't going to regress the non-Rolling builds. Baby steps. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to drop the
osrf_pycommonROS package in favor of using it as a standalone Python library.Part of osrf/osrf_pycommon#80.