Add a python3-dev dependency to tf2_py. #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because it depends on Python.h being available, and it also calls find_package(Python3 Development). While we are in here, we also remove "Development" from the find_package(Python3) calls in tf2_geometry_msgs and tf2_sensor_msgs. In both of those cases, we only need the interpreter, not the header files. Signed-off-by: Chris Lalancette <[email protected]>
|
Pulls: #733
|
ahcorde
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because it depends on Python.h being available, and it also calls find_package(Python3 Development).
While we are in here, we also remove "Development" from the find_package(Python3) calls in tf2_geometry_msgs and tf2_sensor_msgs. In both of those cases, we only need the interpreter, not the header files.
Also see ros2/ros2_tracing#146 (comment) for a long explanation of why we need this.