Future port hpp files

[Timple]

I got deprecation warnings in rolling. But I cannot modify our codebase just yet.

If we would future-port the .hpp extensions this could be done in all codebases already.

If accepted I'll do the same for humble.

[fujitatomoya]

Pulls: #170
Gist: https://gist.githubusercontent.com/fujitatomoya/c4dfecc6a517147b6d57651817b265ce/raw/9649ba0653dfe8a958b1cce887bc955ba65e2195/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15573

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[fujitatomoya]

looks good to me.

[Timple]

I'm assigned, but I do not have merge access here 🙂

[ahcorde]

I prefer not to use here pragma once because is something that we don't use in our codebase. Do you mind to use guard headers and include a License in the top of the file ?

It will be consistent with the changes on rolling

[Timple]

I prefer not to use here pragma once

I can actually just drop it all together? Because the only remaining line (the include) has guards already. Does that make sense?

include a License

Is a License for a single line worth it?

[ahcorde]

I prefer not to use here pragma once

I can actually just drop it all together? Because the only remaining line (the include) has guards already. Does that make sense?

include a License

Is a License for a single line worth it?

The idea is to have the same headers from the original PR https://github.com/ros2/message_filters/pull/135/files#diff-d4113f796930fd2e67a52312cf95f24e1337ec9338ab81947e0d68e9c44f72c7

You can copy them from the rolling branch

[Timple]

Thanks for pointing me to the rolling branch.

Licenses were different for various files. Now they are in line with rolling.

Although I do think it's weird that I'm adding Willow Garage licences to files of 100% my own creation 🙃

[ahcorde]

Pulls: #170
Gist: https://gist.githubusercontent.com/ahcorde/33a75694231fe25459887fdc1f22d1ce/raw/9649ba0653dfe8a958b1cce887bc955ba65e2195/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15618

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[Timple]

@mergify backport humble

[mergify]

backport humble

❌ Command disallowed due to command restrictions in the Mergify configuration.

• sender-permission >= write

[Timple]

Ok, I did say I would do the backport to Humble. But would someone be so kind to ask @Mergifyio?

[ahcorde]

@mergify backport humble

[mergify]

backport humble

✅ Backports have been created

• #172 Future port hpp files (backport #170) has been created for branch humble