-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release ownership of entities after spinning cancelled (backport #2556) #2580
Conversation
* Release ownership of entities after spinning cancelled Signed-off-by: Barry Xu <[email protected]> * Move release action to every exit point in different spin functions Signed-off-by: Barry Xu <[email protected]> * Move wait_result_.reset() before setting spinning to false Signed-off-by: Barry Xu <[email protected]> * Update test code Signed-off-by: Barry Xu <[email protected]> * Move test code to test_executors.cpp Signed-off-by: Barry Xu <[email protected]> --------- Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit 069a001) # Conflicts: # rclcpp/test/rclcpp/executors/test_executors.cpp
Cherry-pick of 069a001 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Barry-Xu-2018 i think this fix should be backported to jazzy, but git found conflict. could you resolve that?
CC: @alsora
Okay. I will fix it. |
Signed-off-by: Barry Xu <[email protected]>
Looks like the Linux runner filled up:
|
The reason for the test failure for Linux-aarch64 is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Barry-Xu-2018 thanks for resolving the conflicts.
This issue was found in ros2/rmw_fastrtps#761.
In code of MoveIt, it used static executor. When the static executor is destructed (The executor is in a cancel state.), and it's time to free up the ownership of entity resources, Fast DDS resources have already been released.
After spinning is cancelled, the Executor should release ownership of entities at once.
This is an automatic backport of pull request #2556 done by Mergify.