Event listeners distinct #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fill reception_sequence_number/publication_sequence_number in all rmw_take_*_with_info() functions Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Add rmw_feature_supported() Signed-off-by: Ivan Santiago Paunovic <[email protected]>
* add stub for content filtered topic Signed-off-by: Chen Lihui <[email protected]>
* Add support for user-specified content filters. Signed-off-by: Andrea Sorbini <[email protected]> * - Resolve memory leak of custom content-filter resources - Add missing package dependencies for rti_connext_dds_custom_sql_filter - Clean up all participants upon factory finalization - Reset context state upon finalization (rmw_connextddsmicro) Signed-off-by: Andrea Sorbini <[email protected]> * Assume non-null options argument Signed-off-by: Andrea Sorbini <[email protected]> * - Return error when retrieving content-filter from a subscription that doesn't have one. - Rename internal functions related to content-filters Signed-off-by: Andrea Sorbini <[email protected]> * Fix compilation error, oops. Signed-off-by: Andrea Sorbini <[email protected]> * - Define RMW_CONNEXT_DEBUG when building Debug libraries. - Make sure participant is enabled before deleting contained entities when using Connext debug libraries. Signed-off-by: Andrea Sorbini <[email protected]> * Resolve memory leak for finalization on error. Signed-off-by: Andrea Sorbini <[email protected]> * Rename content filter public API. Signed-off-by: Andrea Sorbini <[email protected]> * Add client/service QoS getters (ros2#67) Signed-off-by: Mauro Passerino <[email protected]> * Changelogs Signed-off-by: Ivan Santiago Paunovic <[email protected]> * 0.8.1 * Fix cpplint errors (ros2#69) * Use static_cast instead of C-style cast Fixes cpplint error. Signed-off-by: Jacob Perron <[email protected]> * Update NOLINT category Relates to ament/ament_lint#324 Signed-off-by: Jacob Perron <[email protected]> * 0.8.2 Signed-off-by: Audrow Nash <[email protected]> * Update rti-connext-dds dependency to 6.0.1. (ros2#71) Now that this package is available in the ROS bootstrap repository for Ubuntu Focal and Jammy we can bump the expected dependency version. * 0.8.3 * Add rmw listener apis (ros2#44) * Add stubs for setting listener callbacks Signed-off-by: Mauro Passerino <[email protected]> * Address PR suggestions Signed-off-by: Mauro Passerino <[email protected]> * Fix linter issues Signed-off-by: Mauro Passerino <[email protected]> Co-authored-by: Mauro Passerino <[email protected]> Co-authored-by: Alberto Soragna <[email protected]> * Changelog. (ros2#73) Signed-off-by: Chris Lalancette <[email protected]> * 0.9.0 * add stub for content filtered topic Signed-off-by: Chen Lihui <[email protected]> * * Rebased branch asorbini/cft on top of 0.9.0. * Resolved CFT finalization issues on error. * Verified and cleaned up build for rmw_connextddsmicro. Signed-off-by: Andrea Sorbini <[email protected]> * Move custom SQL filter to rmw_connextdds_common Signed-off-by: Andrea Sorbini <[email protected]> * Try to resolve linking error on Windows. Signed-off-by: Andrea Sorbini <[email protected]> * Optionally disable writer-side CFT optimizations to support Windows. Signed-off-by: Andrea Sorbini <[email protected]> * No need to declare private CFT function on Windows. Signed-off-by: Andrea Sorbini <[email protected]> * remove stub implementation for ContentFilteredTopic. Signed-off-by: Tomoya Fujita <[email protected]> * address cpplint error. Signed-off-by: Tomoya Fujita <[email protected]> * Avoid conversion warnings on Windows. Signed-off-by: Andrea Sorbini <[email protected]> * Use strtol instead of sscanf to avoid warnings on Windows. Signed-off-by: Andrea Sorbini <[email protected]> * Avoid finalizing participants if factory is not available. Signed-off-by: Andrea Sorbini <[email protected]> Co-authored-by: mauropasse <[email protected]> Co-authored-by: Ivan Santiago Paunovic <[email protected]> Co-authored-by: Jacob Perron <[email protected]> Co-authored-by: Audrow Nash <[email protected]> Co-authored-by: Steven! Ragnarök <[email protected]> Co-authored-by: Steven! Ragnarök <[email protected]> Co-authored-by: iRobot ROS <[email protected]> Co-authored-by: Mauro Passerino <[email protected]> Co-authored-by: Alberto Soragna <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Chen Lihui <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
…os2#79) * Exclude missing sample info fields when building micro. * Report features individually for each RMW implementation. * Return special value for unsupported sequence numbers. Signed-off-by: Andrea Sorbini <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
|
@asorbini Can you take a look? |
asorbini
approved these changes
Mar 30, 2023
Comment on lines
+388
to
+390
| rmw_event_callback_t new_event_cb_[RMW_EVENT_INVALID] = {}; | ||
| const void * user_data_[RMW_EVENT_INVALID] = {}; | ||
| uint64_t unread_events_count_[RMW_EVENT_INVALID] = {0}; |
There was a problem hiding this comment.
The use of an enum value to define the size of an array is an unsual pattern which caught me by surprise.
It makes sense, but it's not commonly used, so I would add a comment to point it out.
Something like: "These arrays must be able to contain a value for each event kind. RMW_EVENT_INVALID is used because it is the last enumeration of rmw_event_type_t".
There was a problem hiding this comment.
I will address the comment in #76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the fix suggested by @mauropasse here irobot-ros/events-executor#16 (comment)