Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smart quotes (backport #5030) #5044

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 18, 2025

Replace unicode quotation marks and apostrophes with the standard equivalents.

This process should be automated in the future. See #4998 (comment) and https://github.com/sirosen/texthooks


This is an automatic backport of pull request #5030 done by Mergify.

(cherry picked from commit ecdc45f)

# Conflicts:
#	source/Related-Projects/Visualizing-ROS-2-Data-With-Foxglove.rst
#	source/Tutorials/Demos/Quality-of-Service.rst
#	source/Tutorials/Intermediate/Monitoring-For-Parameter-Changes-Python.rst
@mergify mergify bot requested review from clalancette and audrow as code owners February 18, 2025 16:21
@mergify mergify bot added the conflicts label Feb 18, 2025
Copy link
Contributor Author

mergify bot commented Feb 18, 2025

Cherry-pick of ecdc45f has failed:

On branch mergify/bp/humble/pr-5030
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit ecdc45f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   source/Concepts/Basic/About-Client-Libraries.rst
	modified:   source/Concepts/Intermediate/About-Executors.rst
	modified:   source/Concepts/Intermediate/About-Quality-of-Service-Settings.rst
	modified:   source/Contact.rst
	modified:   source/How-To-Guides/DDS-tuning.rst
	modified:   source/How-To-Guides/Getting-Backtraces-in-ROS-2.rst
	modified:   source/How-To-Guides/Overriding-QoS-Policies-For-Recording-And-Playback.rst
	modified:   source/How-To-Guides/Sync-Vs-Async.rst
	modified:   source/How-To-Guides/Using-Python-Packages.rst
	modified:   source/How-To-Guides/Using-callback-groups.rst
	modified:   source/Releases/Beta1-Overview.rst
	modified:   source/Releases/Beta2-Overview.rst
	modified:   source/The-ROS2-Project/Contributing.rst
	modified:   source/The-ROS2-Project/Contributing/Developer-Guide.rst
	modified:   source/The-ROS2-Project/Contributing/Quality-Guide.rst
	modified:   source/The-ROS2-Project/Contributing/Windows-Tips-and-Tricks.rst
	modified:   source/The-ROS2-Project/Feature-Ideas.rst
	modified:   source/Tutorials/Beginner-CLI-Tools/Configuring-ROS2-Environment.rst
	modified:   source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Nodes/Understanding-ROS2-Nodes.rst
	modified:   source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Topics/Understanding-ROS2-Topics.rst
	modified:   source/Tutorials/Beginner-Client-Libraries/Creating-Your-First-ROS2-Package.rst
	modified:   source/Tutorials/Beginner-Client-Libraries/Getting-Started-With-Ros2doctor.rst
	modified:   source/Tutorials/Intermediate/Launch/Creating-Launch-Files.rst
	modified:   source/Tutorials/Intermediate/Launch/Launch-system.rst
	modified:   source/Tutorials/Intermediate/Launch/Using-Substitutions.rst
	modified:   source/Tutorials/Intermediate/Monitoring-For-Parameter-Changes-CPP.rst
	modified:   source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Static-Broadcaster-Py.rst
	modified:   source/Tutorials/Intermediate/URDF/Adding-Physical-and-Collision-Properties-to-a-URDF-Model.rst
	modified:   source/Tutorials/Intermediate/URDF/Building-a-Movable-Robot-Model-with-URDF.rst
	modified:   source/Tutorials/Intermediate/URDF/Building-a-Visual-Robot-Model-with-URDF-from-Scratch.rst
	modified:   source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher.rst
	modified:   source/Tutorials/Intermediate/URDF/Using-Xacro-to-Clean-Up-a-URDF-File.rst
	modified:   source/Tutorials/Intermediate/Writing-an-Action-Server-Client/Py.rst
	modified:   source/index.rst

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   source/Related-Projects/Visualizing-ROS-2-Data-With-Foxglove.rst
	both modified:   source/Tutorials/Demos/Quality-of-Service.rst
	deleted by us:   source/Tutorials/Intermediate/Monitoring-For-Parameter-Changes-Python.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

The following pages are not in the Humble docs:

* source/Related-Projects/Visualizing-ROS-2-Data-With-Foxglove.rst
* source/Tutorials/Intermediate/Monitoring-For-Parameter-Changes-Python.rst

Signed-off-by: Christophe Bedard <[email protected]>
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13396644061/artifacts/2610943402.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5044/index.html in your favorite browser

@christophebedard christophebedard merged commit e08acb3 into humble Feb 18, 2025
5 checks passed
@christophebedard christophebedard deleted the mergify/bp/humble/pr-5030 branch February 18, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants