Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code reference lines in the action (cpp) documentation #5054

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

MortezaHagh
Copy link
Contributor

Reference code lines for the part " The constructor also instantiates a new action server" are corrected. They were refering to lines:

loop_rate.sleep();
}
// Check if goal is done
if (rclcpp::ok()) {

However, they should refer to lines:

his->action_server_ = rclcpp_action::create_server<Fibonacci>(
      this,
      "fibonacci",
      handle_goal,
      handle_cancel,
      handle_accepted);

@ahcorde ahcorde changed the base branch from jazzy to rolling February 24, 2025 17:36
Reference code lines for the part " The constructor also instantiates a new action server" are corrected.

Signed-off-by: MortezaH <[email protected]>
@ahcorde ahcorde merged commit f5e2a68 into ros2:rolling Feb 24, 2025
5 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Feb 24, 2025

https://github.com/Mergifyio backport jazzy

Copy link
Contributor

mergify bot commented Feb 24, 2025

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 24, 2025
Reference code lines for the part " The constructor also instantiates a new action server" are corrected.

Signed-off-by: MortezaH <[email protected]>
(cherry picked from commit f5e2a68)
ahcorde pushed a commit that referenced this pull request Feb 24, 2025
…5055)

Reference code lines for the part " The constructor also instantiates a new action server" are corrected.

Signed-off-by: MortezaH <[email protected]>
(cherry picked from commit f5e2a68)

Co-authored-by: MortezaH <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants