Code

Progress-bar for ros2 bag play#1836

Code

Open

nicolaloi wants to merge 36 commits intoros2:rollingros2/rosbag2:rollingfrom nicolaloi:nicolaloi/bag-play-progress-barnicolaloi/rosbag2:nicolaloi/bag-play-progress-barCopy head branch name to clipboard

+786-1

Commits

Commits on Oct 15, 2024

• Start adding progress-bar for ros2 bag play

  Show description for 616df0d
  nicolaloi

  committed
  616df0d

  Copy full SHA for 616df0d

• clean #include

  Show description for 2cb732d
  nicolaloi

  committed
  2cb732d

  Copy full SHA for 2cb732d

Commits on Oct 20, 2024

• remove new progress bar class, integrate functionality in PlayerImpl

  Show description for 4ba1a8c
  nicolaloi

  committed
  4ba1a8c

  Copy full SHA for 4ba1a8c

Commits on Oct 28, 2024

• convert to template

  Show description for a00bdc4
  nicolaloi

  committed
  a00bdc4

  Copy full SHA for a00bdc4

• Code review

  Show description for 43fa0f8
  nicolaloi

  committed
  43fa0f8

  Copy full SHA for 43fa0f8

Commits on Nov 10, 2024

• update default rate

  Show description for 9cdf5ad
  nicolaloi

  committed
  9cdf5ad

  Copy full SHA for 9cdf5ad

Commits on Nov 17, 2024

• update to avoid synchronization issues

  Show description for bac4e9f
  nicolaloi

  committed
  bac4e9f

  Copy full SHA for bac4e9f

Commits on Nov 18, 2024

• add burst status, reduce cout setprecision

  Show description for 0c99597
  nicolaloi

  committed
  0c99597

  Copy full SHA for 0c99597

Commits on Dec 2, 2024

• Merge branch 'rolling' into nicolaloi/bag-play-progress-bar

  Show description for 372b8a2
  nicolaloi

  authored
  372b8a2

  Copy full SHA for 372b8a2

• some updates after merge with rolling

  Show description for 6051e6c
  nicolaloi

  committed
  6051e6c

  Copy full SHA for 6051e6c

Commits on Dec 4, 2024

• comments

  Show description for 0ef3f26
  nicolaloi

  committed
  0ef3f26

  Copy full SHA for 0ef3f26

Commits on Dec 5, 2024

• Progress bar with nanosecond precision and shorter length

  Show description for 47dff3d
  nicolaloi

  committed
  47dff3d

  Copy full SHA for 47dff3d

Commits on Dec 6, 2024

• change progress bar string, change 'frequency' terms to 'update rate'

  Show description for 19df032
  nicolaloi

  committed
  19df032

  Copy full SHA for 19df032

• comments

  Show description for fb464b0
  nicolaloi

  committed
  fb464b0

  Copy full SHA for fb464b0

Commits on Dec 8, 2024

• Merge branch 'rolling' into nicolaloi/bag-play-progress-bar

  Show description for 6a47a7f
  nicolaloi

  committed
  6a47a7f

  Copy full SHA for 6a47a7f

• add custom space between playback output and progress bar

  Show description for 8625164
  nicolaloi

  committed
  8625164

  Copy full SHA for 8625164

• stubgen

  Show description for 913de31
  nicolaloi

  committed
  913de31

  Copy full SHA for 913de31

Commits on Jan 30, 2025

• Add test_xmllint.py to python packages. (ros2#1879)

  Show description for 5ed1994
  

  clalancette

  authored and

  nicolaloi

  committed
  5ed1994

  Copy full SHA for 5ed1994

• Add more logging info to storage and reader/writer open operations (ros2#1881)

  Show description for ab7cd93
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  ab7cd93

  Copy full SHA for ab7cd93

• Increase timeout to 180s for test_rosbag2_record_end_to_end (ros2#1889)

  Show description for 79ae2d0
  

  Yadunund

  authored and

  nicolaloi

  committed
  79ae2d0

  Copy full SHA for 79ae2d0

• Bugfix. Event publisher not starting for second run after stop (ros2#1888)

  Show description for a7aa5f0
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  a7aa5f0

  Copy full SHA for a7aa5f0

• Bugfix: Recorder discovery does not restart after being stopped (ros2#1894)

  Show description for 1f99a37
  

  oysstu

  authored and

  nicolaloi

  committed
  1f99a37

  Copy full SHA for 1f99a37

• Change type of progress_bar_update_rate to int32_t

  Show description for 6e75a9d
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  6e75a9d

  Copy full SHA for 6e75a9d

• Remove "in_burst_mode" from play_next() method

  Show description for ec11778
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  ec11778

  Copy full SHA for ec11778

• Move progress bar to a separate PlayerProgressBar class

  Show description for 510a248
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  510a248

  Copy full SHA for 510a248

• Move PlayerStatus inside PlayerProgressBar

  Show description for 681c1ed
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  681c1ed

  Copy full SHA for 681c1ed

• Move PlayerProgressBar class to a separate h(c)pp files

  Show description for 3a8301b
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  3a8301b

  Copy full SHA for 3a8301b

• Use Pimpl design pattern for PlayerProgressBar class

  Show description for bb8dc2a
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  bb8dc2a

  Copy full SHA for bb8dc2a

• Replace logger and std::cout with reference to the std::ostream

  Show description for 8798397
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  8798397

  Copy full SHA for 8798397

• Use std::stringstream and rdbuf() to avoid extra data copy to string

  Show description for 8e45042
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  8e45042

  Copy full SHA for 8e45042

• Change type of the progress_bar_separation_lines to the uint32_t

  Show description for 295e137
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  295e137

  Copy full SHA for 295e137

• Simplify logic by using update period in milliseconds

  Show description for 36e07c5
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  36e07c5

  Copy full SHA for 36e07c5

• Regenerate pyi stub files

  Show description for 3709879
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  3709879

  Copy full SHA for 3709879

• Add test_player_progress_bar.cpp with TODOs

  Show description for 2f6e66b
  

  MichaelOrlov

  authored and

  nicolaloi

  committed
  2f6e66b

  Copy full SHA for 2f6e66b

• Add some unit tests

  Show description for 74bc915
  nicolaloi

  committed
  74bc915

  Copy full SHA for 74bc915

• Merge branch 'rolling' into nicolaloi/bag-play-progress-bar

  Show description for 0995532
  nicolaloi

  committed
  0995532

  Copy full SHA for 0995532