[humble] Handle unsupported serialization formats in rosbag2's. #1851
Conversation
…files are scanned for the first support format. All other topics are ignored and the user is informed. Signed-off-by: Jesper Smith <[email protected]>
jespersmith
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
jespersmith
changed the title
jespersmith
changed the title
Signed-off-by: Jesper Smith <[email protected]>
|
I got a branch for rolling, but haven't had the time to test it yet (still on Ubuntu 22.04/Humble). |
Signed-off-by: Jesper Smith <[email protected]>
Signed-off-by: Jesper Smith <[email protected]>
Signed-off-by: Jesper Smith <[email protected]>
jespersmith
force-pushed
the
feature/support-unsupported-serialization-formats
branch
from
8ecba18 to
6e50655
Compare
Signed-off-by: Jesper Smith <[email protected]>
There was a problem hiding this comment.
Hi @jespersmith, Thank you for the PR.
Unfortunately, we can't do API/ABi breaking changes on the stable release like Humble.
Please refer to the https://acodersjourney.com/20-abi-breaking-changes/ for details about ABI breaking changes.
I also see that multiple tests failed during CI run.
Could you please create a new PR against Rolling branch for further review and considerations?
|
@MichaelOrlov Thank you for the response. It's helpful to know it won't make it in humble, saves me doing unnecessary work. I'll look into getting this into rolling. I might need some help with the test cases(specifically what their test goal is), I'll reach out if that is the case. |
Relevant issue
This PR allows ros2 bag play to playback rosbags that have unsupported topics inside.
The implementation finds the first topic with a supported format, and ignores all other topics.
Currently based on humble, as that unblocks us immediately. Once the general approach is approved, we can rebase onto rolling.