Add in python3-dev build dependency. #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this because we call find_package(Python3 Development) in our CMakeLists.txt here. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
requested review from
gbiggs and
james-rms
and removed request for
a team
christophebedard
approved these changes
Nov 22, 2024
|
Pulls: #1863
|
MichaelOrlov
approved these changes
Nov 22, 2024
|
https://github.com/Mergifyio backport jazzy iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
We need this because we call find_package(Python3 Development) in our CMakeLists.txt here. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit ebd9ed0)
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
We need this because we call find_package(Python3 Development) in our CMakeLists.txt here. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit ebd9ed0)
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
We need this because we call find_package(Python3 Development) in our CMakeLists.txt here. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit ebd9ed0)
MichaelOrlov
pushed a commit
that referenced
this pull request
Dec 2, 2024
We need this because we call find_package(Python3 Development) in our CMakeLists.txt here. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit ebd9ed0) Co-authored-by: Chris Lalancette <[email protected]>
MichaelOrlov
pushed a commit
that referenced
this pull request
Dec 3, 2024
We need this because we call find_package(Python3 Development) in our CMakeLists.txt here. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit ebd9ed0) Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this because we call find_package(Python3 Development) in our CMakeLists.txt here.
Also see ros2/ros2_tracing#146 (comment) for a long explanation of why we need this.