[jazzy] Publish clock after delay is over and disable delay on next loops (backport #1861) #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
) * publish clock after the delay is over Signed-off-by: Nicola Loi <[email protected]> * Disable delay period in subsequent loops (ros2 bag play) Signed-off-by: Nicola Loi <[email protected]> * Reset clock publisher timer outisde playback loop Signed-off-by: Nicola Loi <[email protected]> * review Signed-off-by: Nicola Loi <[email protected]> --------- Signed-off-by: Nicola Loi <[email protected]> (cherry picked from commit 15b8260)
mergify
bot
requested review from
gbiggs and
emersonknapp
and removed request for
a team
MichaelOrlov
changed the title
|
Pulls: #1878
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clock_publish_timeris now initialized withautostart = false, so it doesn't immediately start publishing the/clocktopic. It is "activated" later withclock_publish_timer->reset()at the beginning of the playback thread, ensuring that the (optional) user-defined delay period has passed.Additionally, theclock_now starts in a paused state if a delay time is specified by the user. It resumes after the delay period has ended.This is an automatic backport of pull request #1861 done by Mergify.