Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jazzy] Use tmpfs in rosbag2 temporary_directory_fixture (backport #1901) #1904

Open
wants to merge 2 commits into
base: jazzy
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 28, 2025

Trying to address flakiness in the rosbag2_end_to_end tests due to the slow filesystem on CI machines.

  • Use tmpfs in `rosbag2 temporary_directory_fixture if it is available.
  • Added missing rcpputils dependency in rosbag2_test_common package.
  • Use ParametrizedTemporaryDirectoryFixture in the "rosbag2_transport/test_rewrite.cpp".
    This is an automatic backport of pull request Use tmpfs in rosbag2 temporary_directory_fixture #1901 done by Mergify.

* Use tmpfs for rosbag2 temporary_directory_fixture

- Added missing `rcpputils` dependency in rosbag2_test_common package
- Use ParametrizedTemporaryDirectoryFixture in the
"rosbag2_transport/test_rewrite.cpp"

Signed-off-by: Michael Orlov <[email protected]>

* Nitpick from code review. Reuse already created `parent_path`

Signed-off-by: Michael Orlov <[email protected]>

---------

Signed-off-by: Michael Orlov <[email protected]>
(cherry picked from commit 1d60d7b)

# Conflicts:
#	rosbag2_test_common/include/rosbag2_test_common/temporary_directory_fixture.hpp
#	rosbag2_transport/test/rosbag2_transport/test_rewrite.cpp
@mergify mergify bot requested a review from a team as a code owner January 28, 2025 20:03
@mergify mergify bot added the conflicts label Jan 28, 2025
@mergify mergify bot requested review from MichaelOrlov and hidmic and removed request for a team January 28, 2025 20:03
Copy link
Author

mergify bot commented Jan 28, 2025

Cherry-pick of 1d60d7b has failed:

On branch mergify/bp/jazzy/pr-1901
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 1d60d7b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rosbag2_test_common/CMakeLists.txt
	modified:   rosbag2_test_common/package.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rosbag2_test_common/include/rosbag2_test_common/temporary_directory_fixture.hpp
	both modified:   rosbag2_transport/test/rosbag2_transport/test_rewrite.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@MichaelOrlov MichaelOrlov changed the title Use tmpfs in rosbag2 temporary_directory_fixture (backport #1901) [jazzy] Use tmpfs in rosbag2 temporary_directory_fixture (backport #1901) Jan 28, 2025
@MichaelOrlov MichaelOrlov removed the request for review from hidmic January 28, 2025 20:04
@MichaelOrlov MichaelOrlov force-pushed the mergify/bp/jazzy/pr-1901 branch from 1782bca to b52fb4d Compare January 28, 2025 22:27
Signed-off-by: Michael Orlov <[email protected]>
@MichaelOrlov MichaelOrlov force-pushed the mergify/bp/jazzy/pr-1901 branch from b52fb4d to b826a97 Compare January 28, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant