Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Replace deprecated spin_until_future_complete"" #505

Closed
wants to merge 1 commit into from
Closed

Revert "Revert "Replace deprecated spin_until_future_complete"" #505

wants to merge 1 commit into from

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Jun 24, 2022

Reverts #504

Merge this once related prs are ready.

@wjwwood wjwwood mentioned this pull request Jun 24, 2022
Merged
@fujitatomoya fujitatomoya mentioned this pull request Jun 24, 2022
Closed
@audrow audrow changed the base branch from master to rolling June 28, 2022 14:25
@fujitatomoya fujitatomoya mentioned this pull request Jan 23, 2023
Open
@fujitatomoya
Copy link
Contributor

either @wjwwood or @audrow can i have the permission to push this repo? i want to rebase this one.

@audrow audrow requested a review from methylDragon as a code owner January 31, 2023 23:57
@audrow audrow force-pushed the revert-504-revert-499-hliberacki/spin_until branch from a921110 to 5ea04af Compare February 1, 2023 00:00
@wjwwood @audrow
Revert "Revert "Replace deprecated spin_until_future_complete with sp…
16a55ae 
…in_until_complete (#499)" (#504)"

This reverts commit 4318235.

Signed-off-by: Audrow Nash <[email protected]>
@audrow audrow force-pushed the revert-504-revert-499-hliberacki/spin_until branch from 5ea04af to 16a55ae Compare February 1, 2023 00:03
@audrow
Copy link
Member

audrow commented Feb 1, 2023 •
edited
Loading

either @wjwwood or @audrow can i have the permission to push this repo? i want to rebase this one.

I'm not sure how to give you access (and don't have the ability to give others write access to the repo), but I rebased the branch 👍

@christophebedard christophebedard mentioned this pull request Apr 2, 2024
Closed
@christophebedard
Copy link
Member

I've opened #541 to replace this PR.

@christophebedard
Copy link
Member

This can be closed, see #541 (comment)

@clalancette clalancette deleted the revert-504-revert-499-hliberacki/spin_until branch April 10, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wjwwood @fujitatomoya @audrow @christophebedard @clalancette