Revert "Use system installed yaml-cpp 0.6 if available" #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b11d00f. Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
force-pushed
the
revert-8-seanyen/portable
branch
from
c7bd343 to
de7e3d0
Compare
dirk-thomas
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Feel free to either revert now and create a follow up ticket to reapply the change with modification or work on a pull request to address the problem within a day or two.
@seanyen FYI.
ivanpauno
added a commit
that referenced
this pull request
Aug 25, 2020
ivanpauno
added a commit
that referenced
this pull request
Aug 25, 2020
…15)" This reverts commit 251be27. Signed-off-by: Ivan Santiago Paunovic <[email protected]>
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8.
Fixes #14.
rosbag2_transportlinks against the system installedyaml_cppcorrectly, but it then fails to load it at runtime (when a python extension is being loaded).I'm not quite sure what's the problem, maybe
DYLD_LIBRARY_PATHneeds to be updated with the system location ofyaml_cpp_vendor(?). For the moment, I'm reverting the PR that introduced the issue.