Skip to content

Fixed and added tests; refactored updateQuality function #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed and added tests; refactored updateQuality function #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 23 additions & 41 deletions app/gilded-rose.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,51 +19,33 @@ export class GildedRose {

updateQuality() {
for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros'){
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if(this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (this.items[i].sellIn < 11) {
this.items[i].quality = this.items[i].quality + 1
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
if (this.items[i].sellIn < 6) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
}
if (this.items[i].sellIn < 6) {
this.items[i].quality = this.items[i].quality + 1
}
}
if (this.items[i].sellIn == 0) {
this.items[i].quality = 0
}
}
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].sellIn = this.items[i].sellIn - 1;
if (this.items[i].name == 'Aged Brie' && this.items[i].quality < 50){
this.items[i].quality = this.items[i].quality + 1
}
if (this.items[i].sellIn < 0) {
if (this.items[i].name != 'Aged Brie') {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
}
} else {
this.items[i].quality = this.items[i].quality - this.items[i].quality
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
if (this.items[i].name == 'Conjured Mana Cake'){
this.items[i].quality = this.items[i].quality - 1
}
if(this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert' && this.items[i].name != 'Aged Brie'){
this.items[i].quality = this.items[i].quality - 1
}
this.items[i].sellIn= this.items[i].sellIn - 1
}
}

return this.items;
return this.items;
}
}
}
67 changes: 64 additions & 3 deletions test/jest/gilded-rose.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ describe('Gilded Rose', () => {
const items = gildedRose.updateQuality();

// Assert
expect(items[0].name).toBe('bar');
expect(items[0].name).toBe('foo');
});

it('sword quality drops by 1', () => {
Expand All @@ -20,6 +20,67 @@ describe('Gilded Rose', () => {
const items = gildedRose.updateQuality();

// Assert
expect(items[0].quality).toBe(1);
})
expect(items[0].quality).toBe(0);
});
it('conjured quality drops by 2', () => {
// Arrange
const gildedRose = new GildedRose([new Item('Conjured Mana Cake', 7, 4)]);

// Act
const items = gildedRose.updateQuality();

// Assert
expect(items[0].quality).toBe(2);
});
it('sulfuras quality does not drop', () => {
// Arrange
const gildedRose = new GildedRose([new Item('Sulfuras, Hand of Ragnaros', 5, 80)]);

// Act
const items = gildedRose.updateQuality();

// Assert
expect(items[0].quality).toBe(80);
});
it('sulfuras sellIn does not decrease', () => {
// Arrange
const gildedRose = new GildedRose([new Item('Sulfuras, Hand of Ragnaros', 5, 80)]);

// Act
const items = gildedRose.updateQuality();

// Assert
expect(items[0].sellIn).toBe(5);
});
it('sword sellIn decreases', () => {
// Arrange
const gildedRose = new GildedRose([new Item('sword', 7, 17)]);

// Act
const items = gildedRose.updateQuality();

// Assert
expect(items[0].sellIn).toBe(6);
});
it('brie quality limit at 50', () => {
// Arrange
const gildedRose = new GildedRose([new Item('Aged Brie', 7, 50)]);

// Act
const items = gildedRose.updateQuality();

// Assert
expect(items[0].quality).toBe(50);
});
it('backstage quality zero after concert', () => {
// Arrange
const gildedRose = new GildedRose([new Item('Backstage passes to a TAFKAL80ETC concert', 0, 50)]);

// Act
const items = gildedRose.updateQuality();

// Assert
expect(items[0].quality).toBe(0);
});

});