Skip to content

Commit

Permalink
PHP 8.1 minimum version prep
Browse files Browse the repository at this point in the history
  • Loading branch information
rotimi committed Mar 15, 2024
1 parent 85548d6 commit 806d49e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
php: [8.2, 8.1]
php: [8.3, 8.2, 8.1]
# prefer-lowest is causing unit tests to fail when php 7.2 is run against PHPunit 7.x,
# PHPUnit 8.x is the latest stable release that supports PHP 7.2 and that runs fine
# dependency-version: [prefer-lowest, prefer-stable]
Expand All @@ -37,7 +37,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
8 changes: 5 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"require-dev": {
"phpunit/phpunit": "^10.0",
"php-coveralls/php-coveralls": "^2.0",
"rector/rector": "^0.18.0",
"rector/rector": "^1.0.0",
"vimeo/psalm": "^5.4"
},
"autoload": {
Expand All @@ -28,11 +28,13 @@
},
"scripts": {
"test": [
"composer dump",
"Composer\\Config::disableProcessTimeout",
"vendor/bin/phpunit --coverage-text"
],
"rector-clear": "vendor/bin/rector --clear-cache",
"rector": "vendor/bin/rector process src --dry-run -vvv",
"psalm": "vendor/bin/psalm",
"psalm-clear-cache": "vendor/bin/psalm --clear-global-cache && vendor/bin/psalm --clear-cache",
"psalm": "composer psalm-clear-cache && vendor/bin/psalm --threads=1",
"qa": "composer test && composer rector && composer psalm"
}
}
1 change: 0 additions & 1 deletion rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
\Rector\DeadCode\Rector\ClassMethod\RemoveUselessParamTagRector::class,
//\Rector\TypeDeclaration\Rector\ClassMethod\AddArrayReturnDocTypeRector::class,
\Rector\DeadCode\Rector\ClassMethod\RemoveUselessReturnTagRector::class,
\Rector\Php71\Rector\FuncCall\CountOnNullRector::class,
//\Rector\TypeDeclaration\Rector\FunctionLike\ParamTypeDeclarationRector::class,
\Rector\DeadCode\Rector\ClassMethod\RemoveUselessParamTagRector::class
]);
Expand Down
2 changes: 1 addition & 1 deletion src/CallableExecutionTimer.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*/
class CallableExecutionTimer extends ObjectifiedCallable {

final public const NANO_SECOND_TO_SECOND_DIVISOR = 1_000_000_000;
public const NANO_SECOND_TO_SECOND_DIVISOR = 1_000_000_000;

/**
* Holds execution stats for all function / method calls across all instances of this class
Expand Down

0 comments on commit 806d49e

Please sign in to comment.