Only include WPF on .NET Framework project #744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
The WPF platform files are included by this condition :
but the WPF framework included by the UseWPF property is included by the condition :
Use the same condition to not include Wpf when not in NET Framework project.
When creating a test project targeting net5.0/net6.0 that reference a library that using this library, the build fail because the WPF FrameworkReferences is required, this force to use net5.0-windows or net6.0-windows. The build fail with error NETSDK1136.
🆕 What is the new behavior (if this is a feature change)?
WPF is now only required on .NET Framework project.
💥 Does this PR introduce a breaking change?
No because the WPF framework was required but the platform files was not included on non .NET Framework project.
🐛 Recommendations for testing
Reference the library in a project targeting net5.0/net6.0, the build should not fail with error NETSDK1136.
📝 Links to relevant issues/docs
Issue #568
🤔 Checklist before submitting