Install missing skin via composer on system initialization #254
Conversation
bjalbor
changed the title
|
Ping |
|
@thomascube Do you see any technical reason not to merge this? (I'm ready to pick up the work, just want to know your opinion.) |
|
@pabzm No objections. Maybe even configure a non-default skin in the docker-compose.* tests to verify the process works? |
| @@ -94,6 +94,20 @@ if [[ "$1" == apache2* || "$1" == php-fpm || "$1" == bin* ]]; then | |||
| ${ROUNDCUBEMAIL_PLUGINS_SH}; | |||
| fi | |||
|
|
|||
| if [ ! -d skins/${ROUNDCUBEMAIL_SKIN} ]; then | |||
There was a problem hiding this comment.
Add echo like above for plugins installation. Just to be consistent.
|
@bjalbor Could you try to extend |
|
@pabzm |
|
Hi there,
sorry for missing the message.
I'll try to find some time next week for taking care of adding you
suggestion.
Regards
Pablo Zmdl ***@***.***> schrieb am Fr., 8. Nov. 2024, 08:04:
… @bjalbor <https://github.com/bjalbor> Could you try to extend
tests/docker-compose.test-* so that they install a non-default skin, so
this feature is tested?
—
Reply to this email directly, view it on GitHub
<#254 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7HJE5NZE4OODDCTXXAIHDZ7RPADAVCNFSM6AAAAABI6P3GOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRTHEYTQMZVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@bjalbor No pressure, we've got time! Thank you for the notice, and thank you for working on this! |
|
I hope everything is fine now. Sorry, if something is still missing. To be honest this is my very first contribution to a project in github 😊 |
Only classic skin ist included in core. So if you define ROUNDCUBEMAIL_SKIN to anything other, you will get an 404 (also see #243) unless you install missing skin. This contribution will install the missing skin on system startup.