-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create template object for message list actions #9038
Conversation
e94aefe
to
27b358f
Compare
I'm not sure I like |
You don't like the name or your don't like having a template object for it?
Understood. Nothing in this PR changes the look, the image I posted was created with |
I am now looking at the idea of allowing users to customise the actions available in the hover menu via their settings. I was thinking about something like this: And use drag & drop to allow users to customise the order of the icons (with some hint text inside the box to inform users). Either way there are some other details like the skin needs to somehow register that it supports the object so we know to show the settings section. May be this could be done in the config section of the meta file like with the layouts. I think there are 3 options:
I think I prefer 2 or 3 but I am happy work on any of them. I think the hover menu is a good solution, it adds useful functionality to the mail screen and will be useful in any skin with widescreen layout. In developing this PR I have also been trying things with different skins and it does work in list mode as well – rather than taking up screen space with an additional column for more options the options only come up on hover. I’m also trying to make it a little more generic at least on the JS side, so similar menus could easily be added to other lists if required. |
As for the configuration, I would put it in "List options" dialog instead. I would not bother with order/drag-n-drop/icons. |
1267cfa
to
90b61c5
Compare
390c73b
to
a9cb19c
Compare
i have simplified this PR, the only aim now is to create a template object for the list actions widget so that plugins and extended skins can interact with it easier. |
a9cb19c
to
0953b7a
Compare
882d023
to
18a20a5
Compare
I acknowledge that 9427ec1 is very new, I thought it might be helpful to setup a place to discus the possibilities of this new menu. I think the idea is great, better than adding extra columns for every action a user wants.
The first commit in this PR moves creation of the menu from the Elastic JS code into the core so in the future other skins could benefit from it and also plugins. Note: there is more to do, if Roundcube wants to go this way, more of the JS for the menu needs to move into
app.js
or may belist.js
so it becomes a core function rather than a skin one.There is a lot more to do, I wanted to post this draft now to start the discussion and get feedback on if its worth working on.
Unrelated to the organization of the code I have also been playing with the look of the menu. At the moment I have this: