Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codemirror from 5.65.16 to 6.0.1 #9488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 8, 2024

Bumps codemirror from 5.65.16 to 6.0.1.

Changelog

Sourced from codemirror's changelog.

6.0.1 (2022-06-30)

Bug fixes

Work around limitations in tree-shaking software that prevented basicSetup from being removed when unused.

6.0.0 (2022-06-08)

Breaking changes

Change the package name from @codemirror/example-setup to just codemirror.

The package no longer exports EditorState (since that is no longer necessary to set up a basic editor).

New features

The new minimalSetup export provides a minimal set of editor extensions.

0.20.0 (2022-04-20)

Breaking changes

Update dependencies to 0.20.0

0.19.3 (2022-03-30)

New features

Add the extension that shows a crosshair cursor when Alt is held down to the basic setup.

0.19.1 (2021-12-13)

New features

The basic setup now includes the dropCursor extension.

0.19.0 (2021-08-11)

Breaking changes

Update dependencies to 0.19.0

0.18.2 (2021-05-25)

Bug fixes

Fix too-low dependency on @​codemirror/gutter that could cause broken upgrades.

0.18.1 (2021-05-15)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [codemirror](https://github.com/codemirror/basic-setup) from 5.65.16 to 6.0.1.
- [Changelog](https://github.com/codemirror/basic-setup/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codemirror/basic-setup/commits/6.0.1)

---
updated-dependencies:
- dependency-name: codemirror
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 8, 2024
@pabzm pabzm self-assigned this Jun 12, 2024
@pabzm
Copy link
Member

pabzm commented Jun 12, 2024

@alecpl, @mvorisek Just to get you on board: codemirror v6 isn't provided as a ready-to-use browser bundle anymore. We'll have to build it ourselves using a Javascript bundler. I'm happy to implement that, but I'd like to know if you have any concerns about this, before I spend time on it.

Also: do you have preferred bundling tools? I'd use rollup, if I'm free to choose, because it's recommended by the codemirror authors.

@alecpl
Copy link
Member

alecpl commented Jun 13, 2024

That would be something new for the project (we only build small developer deps), but if there's no other option...

I'm not that good with npm tooling. For that reason we also do not build Bootstrap, but we could and probably would win on output size. Although, at this point it might be a lot of work not worth the effort.

As for the codemirror, unless there's some serious issues that will not be fixed in v5, we don't have to rush with this update.

@pabzm
Copy link
Member

pabzm commented Jun 13, 2024

unless there's some serious issues that will not be fixed in v5, we don't have to rush with this update

The situation is a little unclear, since the codemirror5-repo has had a few commits since the last published version, but its README also says that version 6 is "much more actively maintained". But I agree that we don't have to rush this.

Copy link

@pabzm, @alecpl
🛎️ This PR has had no activity in two weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants