ManageSieve: Fix timeformat processing for frontend the time picker #9688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabzm
approved these changes
Nov 5, 2024
|
added it |
|
@alecpl I'll merge this in one week unless you object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally to the missing time formatters described in #9655, the function
sieve_formattime()has also two additional bugs processing the existing time formats.First the 12h format is not processed properly e.g. resulting in 24h format with am/pm specifiers in the timeformat is set to
h:i a. This is the result of the calculated 12h value not actually being used to the string construction.And second having seconds in the timeformat will append a dangling
sto the number due the fall through of the last switch case in the function.This PR fix both issues (in separate commits).