fix(ci): add git config to release-batch workflow#262
fix(ci): add git config to release-batch workflow#262KooshaPari wants to merge 300 commits intorouter-for-me:mainfrom
Conversation
Summary of ChangesHello @KooshaPari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a significant upgrade to the project's operational and development infrastructure. While addressing a specific CI issue, it expands into a broader initiative to harden CI/CD pipelines, refactor the core into a reusable library, and vastly improve documentation. The changes aim to streamline development workflows, enhance deployment flexibility, and provide clearer guidance for integrating and operating the proxy with a wider array of LLM providers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| func logCodexWebsocketDisconnected(sessionID string, authID string, wsURL string, reason string, err error) { | ||
| if err != nil { | ||
| log.Infof("codex websockets: upstream disconnected session=%s auth=%s url=%s reason=%s err=%v", strings.TrimSpace(sessionID), strings.TrimSpace(authID), strings.TrimSpace(wsURL), strings.TrimSpace(reason), err) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| } | ||
|
|
||
| func logCodexWebsocketConnected(sessionID string, authID string, wsURL string) { | ||
| log.Infof("codex websockets: upstream connected session=%s auth=%s url=%s", strings.TrimSpace(sessionID), strings.TrimSpace(authID), strings.TrimSpace(wsURL)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| } | ||
|
|
||
| func (e *CodexWebsocketsExecutor) ExecuteStream(ctx context.Context, auth *cliproxyauth.Auth, req cliproxyexecutor.Request, opts cliproxyexecutor.Options) (_ *cliproxyexecutor.StreamResult, err error) { | ||
| log.Debugf("Executing Codex Websockets stream request with auth ID: %s, model: %s", auth.ID, req.Model) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| } | ||
|
|
||
| func userIDCacheKey(apiKey string) string { | ||
| sum := sha256.Sum256([]byte(apiKey)) |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic hashing algorithm on sensitive data High
| auth.Metadata["last_refresh"] = time.Now().Format(time.RFC3339) | ||
|
|
||
| // Log the new access token (masked) after successful refresh | ||
| log.Debugf("iflow executor: token refresh successful, new: %s", util.HideAPIKey(tokenData.AccessToken)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| } | ||
|
|
||
| func writeWSError(conn *websocket.Conn, err error) { | ||
| _ = conn.WriteMessage(websocket.TextMessage, []byte(`{"error":"`+err.Error()+`"}`)) |
Check failure
Code scanning / CodeQL
Potentially unsafe quoting Critical
| AuthValue: authValue, | ||
| }) | ||
|
|
||
| httpResp, errDo := httpClient.Do(httpReq) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in network request Critical
| } | ||
| if attempt+1 < attempts { | ||
| delay := antigravityNoCapacityRetryDelay(attempt) | ||
| log.Debugf("antigravity executor: no capacity for model %s, retrying in %s (attempt %d/%d)", baseModel, delay, attempt+1, attempts) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| } | ||
| if attempt+1 < attempts { | ||
| delay := antigravityNoCapacityRetryDelay(attempt) | ||
| log.Debugf("antigravity executor: no capacity for model %s, retrying in %s (attempt %d/%d)", baseModel, delay, attempt+1, attempts) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| } | ||
| if attempt+1 < attempts { | ||
| delay := antigravityNoCapacityRetryDelay(attempt) | ||
| log.Debugf("antigravity executor: no capacity for model %s, retrying in %s (attempt %d/%d)", baseModel, delay, attempt+1, attempts) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a very large set of changes, including a major architectural refactoring to a "library-first" approach, significant enhancements to CI/CD, new provider support, and a complete documentation overhaul. The changes are extensive and go far beyond the scope suggested by the PR title and description ("fix(ci): add git config to release-batch workflow"). While the overall direction and quality of the changes are very high, I have a few points of feedback. Notably, config.yaml has been removed from .gitignore, which poses a security risk of leaking credentials and should be reverted. I've also identified a couple of areas in the new CI scripts that could be made more robust and a potentially undocumented breaking change in the configuration.
| @@ -1,35 +1,26 @@ | |||
| # Binaries | |||
There was a problem hiding this comment.
The config.yaml file is no longer being ignored. This poses a significant security risk as it could lead to accidental commitment of sensitive information like API keys. It is strongly recommended to add config.yaml back to the .gitignore file to prevent secrets from being checked into version control.
| mapfile -t discovered_hosts < <( | ||
| rg -No --hidden \ | ||
| --glob '!docs/**' \ | ||
| --glob '!**/*_test.go' \ | ||
| --glob '!**/node_modules/**' \ | ||
| --glob '!**/*.png' \ | ||
| --glob '!**/*.jpg' \ | ||
| --glob '!**/*.jpeg' \ | ||
| --glob '!**/*.gif' \ | ||
| --glob '!**/*.svg' \ | ||
| --glob '!**/*.webp' \ | ||
| 'https?://[^"\047 )\]]+' \ | ||
| cmd pkg sdk scripts .github/workflows config.example.yaml README.md README_CN.md 2>/dev/null \ | ||
| | awk -F'://' '{print $2}' \ | ||
| | cut -d/ -f1 \ | ||
| | cut -d: -f1 \ | ||
| | tr '[:upper:]' '[:lower:]' \ | ||
| | sort -u | ||
| ) |
There was a problem hiding this comment.
Using 2>/dev/null to suppress rg error messages can hide unexpected issues. A cleaner approach is to use the --no-messages flag, which is specifically designed to suppress errors about files that rg can't read, without hiding other potential problems.
| mapfile -t discovered_hosts < <( | |
| rg -No --hidden \ | |
| --glob '!docs/**' \ | |
| --glob '!**/*_test.go' \ | |
| --glob '!**/node_modules/**' \ | |
| --glob '!**/*.png' \ | |
| --glob '!**/*.jpg' \ | |
| --glob '!**/*.jpeg' \ | |
| --glob '!**/*.gif' \ | |
| --glob '!**/*.svg' \ | |
| --glob '!**/*.webp' \ | |
| 'https?://[^"\047 )\]]+' \ | |
| cmd pkg sdk scripts .github/workflows config.example.yaml README.md README_CN.md 2>/dev/null \ | |
| | awk -F'://' '{print $2}' \ | |
| | cut -d/ -f1 \ | |
| | cut -d: -f1 \ | |
| | tr '[:upper:]' '[:lower:]' \ | |
| | sort -u | |
| ) | |
| mapfile -t discovered_hosts < <( | |
| rg -No --hidden --no-messages \ | |
| --glob '!docs/**' \ | |
| --glob '!**/*_test.go' \ | |
| --glob '!**/node_modules/**' \ | |
| --glob '!**/*.png' \ | |
| --glob '!**/*.jpg' \ | |
| --glob '!**/*.jpeg' \ | |
| --glob '!**/*.gif' \ | |
| --glob '!**/*.svg' \ | |
| --glob '!**/*.webp' \ | |
| 'https?://[^"\047 )\\]]+' \ | |
| cmd pkg sdk scripts .github/workflows config.example.yaml README.md README_CN.md \ | |
| | awk -F'://' '{print $2}' \ | |
| | cut -d/ -f1 \ | |
| | cut -d: -f1 \ | |
| | tr '[:upper:]' '[:lower:]' \ | |
| | sort -u | |
| ) |
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| report="docs/reports/fragemented/OPEN_ITEMS_VALIDATION_2026-02-22.md" |
There was a problem hiding this comment.
The report path is hardcoded with the date 2026-02-22. This is brittle and will require manual updates for future reports. To make the script more robust, consider dynamically finding the latest report file in the docs/reports/fragemented/ directory instead of hardcoding the filename.
| report="docs/reports/fragemented/OPEN_ITEMS_VALIDATION_2026-02-22.md" | |
| report_dir="docs/reports/fragemented" | |
| report="$(find "$report_dir" -name 'OPEN_ITEMS_VALIDATION_*.md' | sort -r | head -n 1)" |
| proxy-url: "" | ||
|
|
||
| # When true, unprefixed model requests only use credentials without a prefix (except when prefix == model name). | ||
| force-model-prefix: false |
There was a problem hiding this comment.
The passthrough-headers configuration option appears to have been removed in this change. If this is an intentional breaking change, it should be documented in the release notes or a migration guide to inform users who might be relying on this feature for forwarding upstream headers.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
2 participants
Adds git config to fix 'Committer identity unknown' error in release-batch workflow