fix: resolve executor compile regressions#265
fix: resolve executor compile regressions#265KooshaPari wants to merge 421 commits intorouter-for-me:mainfrom
Conversation
# Conflicts: # docs/planning/reports/issue-wave-gh-next21-lane-6.md # pkg/llmproxy/api/modules/amp/routes_test.go
These fields are not supported by Codex Responses API and cause upstream errors. Fixes: router-for-me#1667
- Replace manual prefix/suffix checks with strings.TrimPrefix/TrimSuffix - Remove unused functions and variables in kiro_executor.go and request_logger.go - Move default case to the end of switch statement in kiro_executor.go - Fix function signatures and call sites in kiro_executor.go where arguments were immediately overwritten Co-authored-by: Cursor <cursoragent@cursor.com>
- Added unit tests for internal/auth packages (codex, copilot, gemini, kiro). - Added unit tests for internal/runtime/executor, specifically for Kiro executor. - Added unit tests for various internal translators. - Improved internal/api and sdk test coverage. - Fixed a race condition in Kiro social authentication callback server. - Updated .gitignore to exclude build artifacts and coverage files. - Cleaned up go.mod and go.sum with go mod tidy. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…rs and fix kiro_websearch functions This commit: - Updates cmd/codegen/main.go to support multiple templates and directories. - Embeds GeneratedConfig in internal/config/Config. - Restores SSE and message ID functions in internal/translator/kiro/claude/kiro_websearch.go. - Adds pkg/llmproxy/ directory structure for shared components. - Fixes missing strings import in generated config files. Co-authored-by: Cursor <cursoragent@cursor.com>
Renamed references to CLIProxyAPIPlus to cliproxyapi++ (display) and cliproxyapi-plusplus (technical). Updated GitHub remote and internal URLs. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…260223-v2 docs: replace marketing language with concise technical wording
…-20260223 merge: absorb heliosharness parity branch functional delta
Summary of ChangesHello @KooshaPari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on stabilizing the executor by resolving several compile regressions that impacted various LLM provider integrations. Beyond critical bug fixes, it significantly enhances the project's development and operational experience through new CI/CD pipelines, comprehensive documentation, and improved Docker deployment. The changes aim to provide a more robust, maintainable, and user-friendly platform for managing LLM proxies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
This comment was marked as spam.
This comment was marked as spam.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a significant refactoring to move core logic into a reusable pkg/llmproxy library, along with new automation tools for project management and releases. While the architectural direction is positive, there are several technical issues in the new scripts and tools. Specifically, the Docker initialization script uses fragile sed commands that can fail or lead to configuration corruption if environment variables contain special characters. The boardsync tool contains an unsafe string slicing function that is not UTF-8 aware, and several documentation files contain hardcoded absolute paths from a local development environment. Additionally, there are consistent typos in directory names and hardcoded dates in filenames that should be made dynamic for better maintainability.
| sed -i "s/^host:.*/host: \"${CLIPROXY_HOST}\"/" "${CONFIG_FILE}" 2>/dev/null || \ | ||
| sed -i '' "s/^host:.*/host: \"${CLIPROXY_HOST}\"/" "${CONFIG_FILE}" 2>/dev/null || true |
There was a problem hiding this comment.
Using sed with a fixed delimiter (in this case /) to inject environment variables into a configuration file is fragile. If the environment variable (e.g., CLIPROXY_HOST or CLIPROXY_SECRET_KEY) contains the delimiter character, the sed command will fail. Furthermore, using double quotes around the variable in the sed command can lead to shell injection or command failure if the variable contains double quotes. Since this is a Go project, a more robust approach would be to handle these overrides directly within the application's configuration loader or use a dedicated YAML manipulation tool.
| func shrink(s string, max int) string { | ||
| if len(s) <= max { | ||
| return s | ||
| } | ||
| return s[:max] | ||
| } |
There was a problem hiding this comment.
The shrink function performs a byte-level slice on a string. In Go, strings are UTF-8 encoded, and slicing at an arbitrary byte index can break multi-byte characters, leading to invalid UTF-8 strings or even a panic if the slice index is out of bounds. It is safer to convert the string to a rune slice before slicing or use the utf8 package to find a valid character boundary.
| func shrink(s string, max int) string { | |
| if len(s) <= max { | |
| return s | |
| } | |
| return s[:max] | |
| } | |
| func shrink(s string, max int) string { | |
| runes := []rune(s) | |
| if len(runes) <= max { | |
| return s | |
| } | |
| return string(runes[:max]) | |
| } |
|
|
||
| This folder is a deterministic backup of 2026-updated Markdown fragments for consolidation and merge safety. | ||
|
|
||
| - Source docs: `/Users/kooshapari/temp-PRODVERCEL/485/kush/cliproxyapi-plusplus/docs/features/architecture` |
There was a problem hiding this comment.
The documentation contains a hardcoded absolute path from a local development environment. This should be replaced with a relative path to ensure the documentation remains valid and professional across different environments and for other contributors.
| - Source docs: `/Users/kooshapari/temp-PRODVERCEL/485/kush/cliproxyapi-plusplus/docs/features/architecture` | |
| - Source docs: `./docs/features/architecture` |
| Items: board, | ||
| } | ||
|
|
||
| const base = "CLIPROXYAPI_2000_ITEM_EXECUTION_BOARD_2026-02-22" |
There was a problem hiding this comment.
The filename base contains a hardcoded date. For a synchronization tool, it is generally better to generate the date dynamically using time.Now() to ensure that generated artifacts are correctly timestamped based on when the tool is actually run. Note that this also applies to other hardcoded date strings in this file (e.g., line 116).
| const base = "CLIPROXYAPI_2000_ITEM_EXECUTION_BOARD_2026-02-22" | |
| base := fmt.Sprintf("CLIPROXYAPI_2000_ITEM_EXECUTION_BOARD_%s", time.Now().Format("2006-01-02")) |
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| report="${REPORT_PATH:-docs/reports/fragemented/OPEN_ITEMS_VALIDATION_2026-02-22.md}" |
There was a problem hiding this comment.
There is a consistent typo in the path name: fragemented should be fragmented. This typo appears in multiple directory names and script references throughout the PR. Correcting this will improve maintainability and prevent confusion.
| report="${REPORT_PATH:-docs/reports/fragemented/OPEN_ITEMS_VALIDATION_2026-02-22.md}" | |
| report="${REPORT_PATH:-docs/reports/fragmented/OPEN_ITEMS_VALIDATION_2026-02-22.md}" |
|
|
||
| This folder is a deterministic backup of 2026-updated Markdown fragments for consolidation and merge safety. | ||
|
|
||
| - Source docs: `/Users/kooshapari/temp-PRODVERCEL/485/kush/cliproxyapi-plusplus/docs/features/providers` |
There was a problem hiding this comment.
The documentation contains a hardcoded absolute path from a local development environment. This should be replaced with a relative path.
| - Source docs: `/Users/kooshapari/temp-PRODVERCEL/485/kush/cliproxyapi-plusplus/docs/features/providers` | |
| - Source docs: `./docs/features/providers` |
2 participants
Fix compile regression fallout with minimal scope: Kiro model mapping brace fix; remove duplicate GitHub Copilot CloseExecutionSession; Codex websocket logger variable usage; Claude token assignment; Kiro OIDC region regex symbol fix.