Skip to content

fix: reuse existing secret-key on startup; add upstream sync workflow#39

Open
bighamx wants to merge 2 commits intorouter-for-me:mainfrom
bighamx:main
Open

fix: reuse existing secret-key on startup; add upstream sync workflow#39
bighamx wants to merge 2 commits intorouter-for-me:mainfrom
bighamx:main

Conversation

@bighamx
Copy link
Copy Markdown

@bighamx bighamx commented Mar 27, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the start_cliproxyapi and restart_cliproxyapi functions to attempt to retrieve an existing secret-key from the configuration before falling back to generating a random password. The review feedback correctly identifies that this logic is duplicated across both functions and suggests extracting it into a reusable helper function to adhere to DRY principles.

@bighamx
Copy link
Copy Markdown
Author

bighamx commented Mar 27, 2026

Implemented the refactor suggestion by extracting the duplicated secret-key lookup/generation logic into a shared helper and reusing it in both start_cliproxyapi and restart_cliproxyapi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant