valueStyleBuilder enhancements #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Take node as additional argument * Return value PropertyOverrides can optionally take `onLongPress` and `cursor`, and `style` is now optional
The search term is a regex, but highlighting assumed simple substring matching. This is now fixed.
New theme property highlightOnlyRegExpGroups that when true will cause only the matching groups of the search term regexp to be highlighted, rather than the whole expression. This is only an approximation right now, since dart regexp does not give the position of each matching group. Defaults to old behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration:
Enhance
valueStyleBuilderfor more complex use cases:styleinPropertyOverridesis now optional (if not specified, it will default to what is specified in the theme, same as before)PropertyOverridescan optionally specifyonLongPressand a mousecursorUpdating version to 0.3.0 since this has breaking changes. Took opportunity to bump dependencies again so that the example could compile cleanly on windows desktop.
This builds off the https://github.com/rows/json_data_explorer/tree/chore/bump-dependencies branch which was never merged. Ideally that would get merged and published as 0.2.0, then this would get discussed/finalized/merged and published as 0.3.0.