Skip to content

Commit 8bcff1b

Browse files
amanmahajan7nstepien
authored and
royue
committed
Update deps (Comcast#3924)
* biome * prettier * update eslint packages * Enable `'vitest/require-import-vi-mock': 1,` * update more deps * Update eslint.config.js Co-authored-by: Nicolas Stepien <[email protected]> * Update package.json Co-authored-by: Nicolas Stepien <[email protected]> * `^` -> `~` --------- Co-authored-by: Nicolas Stepien <[email protected]>
1 parent d67e6fd commit 8bcff1b

File tree

7 files changed

+44
-34
lines changed

7 files changed

+44
-34
lines changed

‎eslint.config.js‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export default defineConfig([
102102
'no-unsafe-finally': 1,
103103
'no-unsafe-negation': [1, { enforceForOrderingRelations: true }],
104104
'no-unsafe-optional-chaining': [1, { disallowArithmeticOperators: true }],
105-
'no-unused-private-class-members': 0,
105+
'no-unused-private-class-members': 0, // replaced by @typescript-eslint/no-unused-private-class-members
106106
'no-unused-vars': 0, // replaced by @typescript-eslint/no-unused-vars
107107
'no-use-before-define': 0,
108108
'no-useless-backreference': 1,
@@ -588,6 +588,7 @@ export default defineConfig([
588588
],
589589
'@typescript-eslint/no-shadow': 0,
590590
'@typescript-eslint/no-unused-expressions': 0,
591+
'@typescript-eslint/no-unused-private-class-members': 0,
591592
'@typescript-eslint/no-unused-vars': [1, { ignoreRestSiblings: true }],
592593
'@typescript-eslint/no-use-before-define': 0,
593594
'@typescript-eslint/no-useless-constructor': 0,
@@ -673,7 +674,9 @@ export default defineConfig([
673674
'vitest/prefer-to-have-length': 1,
674675
'vitest/prefer-todo': 1,
675676
'vitest/prefer-vi-mocked': 1,
677+
'vitest/require-awaited-expect-poll': 1,
676678
'vitest/require-hook': 0,
679+
'vitest/require-import-vi-mock': 1,
677680
'vitest/require-local-test-context-for-concurrent-snapshots': 0,
678681
'vitest/require-mock-type-parameters': 0,
679682
'vitest/require-to-throw-message': 0,

‎package.json‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@
6161
"@dnd-kit/core": "^6.3.1",
6262
"@dnd-kit/modifiers": "^9.0.0",
6363
"@dnd-kit/sortable": "^10.0.0",
64-
"@biomejs/biome": "2.3.7",
65-
"@eslint-react/eslint-plugin": "^2.0.2",
66-
"@eslint/markdown": "^7.3.0",
64+
"@biomejs/biome": "2.3.8",
65+
"@eslint-react/eslint-plugin": "^2.3.12",
66+
"@eslint/markdown": "^7.5.1",
6767
"@faker-js/faker": "^10.0.0",
6868
"@ianvs/prettier-plugin-sort-imports": "^4.6.2",
6969
"@linaria/core": "^6.3.0",
@@ -74,33 +74,33 @@
7474
"@tanstack/react-router": "^1.132.31",
7575
"@tanstack/router-plugin": "^1.132.31",
7676
"@types/node": "^24.8.0",
77-
"@typescript-eslint/eslint-plugin": "^8.39.1",
78-
"@typescript-eslint/parser": "^8.39.1",
77+
"@typescript-eslint/eslint-plugin": "^8.48.1",
78+
"@typescript-eslint/parser": "^8.48.1",
7979
"@vitejs/plugin-react": "^5.1.1",
80-
"@vitest/browser-playwright": "^4.0.14",
81-
"@vitest/coverage-istanbul": "^4.0.14",
82-
"@vitest/eslint-plugin": "^1.3.4",
80+
"@vitest/browser-playwright": "^4.0.15",
81+
"@vitest/coverage-istanbul": "^4.0.15",
82+
"@vitest/eslint-plugin": "^1.5.1",
8383
"clsx": "^2.1.1",
8484
"ecij": "^0.2.0",
85-
"eslint": "^9.36.0",
85+
"eslint": "^9.39.1",
8686
"eslint-plugin-jest-dom": "^5.5.0",
8787
"eslint-plugin-react": "^7.37.5",
88-
"eslint-plugin-react-hooks": "^7.0.0",
88+
"eslint-plugin-react-hooks": "^7.0.1",
8989
"eslint-plugin-sonarjs": "^3.0.5",
90-
"eslint-plugin-testing-library": "^7.10.0",
90+
"eslint-plugin-testing-library": "^7.13.5",
9191
"jspdf": "^3.0.1",
9292
"jspdf-autotable": "^5.0.2",
9393
"lodash": "^4.17.21",
9494
"react": "^18.3.1",
9595
"react-dom": "^18.3.1",
9696
"playwright": "^1.57.0",
9797
"postcss": "^8.5.2",
98-
"prettier": "3.6.2",
98+
"prettier": "3.7.3",
9999
"rolldown": "^1.0.0-beta.51",
100100
"rolldown-plugin-dts": "^0.18.0",
101101
"typescript": "~5.9.2",
102102
"vite": "npm:rolldown-vite@^7.2.5",
103-
"vitest": "^4.0.14",
103+
"vitest": "^4.0.15",
104104
"vitest-browser-react": "^2.0.2"
105105
},
106106
"peerDependencies": {

‎src/EditCell.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ const cellEditing = css`
5353
type SharedCellRendererProps<R, SR> = Pick<CellRendererProps<R, SR>, 'colSpan'>;
5454

5555
interface EditCellProps<R, SR>
56-
extends Omit<RenderEditCellProps<R, SR>, 'onRowChange' | 'onClose'>,
56+
extends
57+
Omit<RenderEditCellProps<R, SR>, 'onRowChange' | 'onClose'>,
5758
SharedCellRendererProps<R, SR> {
5859
rowIdx: number;
5960
onRowChange: (row: R, commitChanges: boolean, shouldFocusCell: boolean) => void;

‎src/TreeDataGrid.tsx‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@ import { useDefaultRenderers } from './DataGridDefaultRenderersContext';
2525
import GroupedRow from './GroupRow';
2626
import { defaultRenderRow } from './Row';
2727

28-
export interface TreeDataGridProps<R, SR = unknown, K extends Key = Key>
29-
extends Omit<
30-
DataGridProps<R, SR, K>,
31-
'columns' | 'role' | 'aria-rowcount' | 'rowHeight' | 'onFill' | 'isRowSelectionDisabled'
32-
> {
28+
export interface TreeDataGridProps<R, SR = unknown, K extends Key = Key> extends Omit<
29+
DataGridProps<R, SR, K>,
30+
'columns' | 'role' | 'aria-rowcount' | 'rowHeight' | 'onFill' | 'isRowSelectionDisabled'
31+
> {
3332
columns: readonly Column<NoInfer<R>, NoInfer<SR>>[];
3433
rowHeight?: Maybe<number | ((args: RowHeightArgs<NoInfer<R>>) => number)>;
3534
groupBy: readonly string[];

‎src/types.ts‎

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,8 @@ export interface RenderHeaderCellProps<TRow, TSummaryRow = unknown> {
163163
}
164164

165165
interface BaseCellRendererProps<TRow, TSummaryRow = unknown>
166-
extends Omit<React.ComponentProps<'div'>, 'children'>,
166+
extends
167+
Omit<React.ComponentProps<'div'>, 'children'>,
167168
Pick<
168169
DataGridProps<TRow, TSummaryRow>,
169170
'onCellMouseDown' | 'onCellClick' | 'onCellDoubleClick' | 'onCellContextMenu'
@@ -172,8 +173,10 @@ interface BaseCellRendererProps<TRow, TSummaryRow = unknown>
172173
selectCell: (position: Position, options?: SelectCellOptions) => void;
173174
}
174175

175-
export interface CellRendererProps<TRow, TSummaryRow>
176-
extends BaseCellRendererProps<TRow, TSummaryRow> {
176+
export interface CellRendererProps<TRow, TSummaryRow> extends BaseCellRendererProps<
177+
TRow,
178+
TSummaryRow
179+
> {
177180
column: CalculatedColumn<TRow, TSummaryRow>;
178181
row: TRow;
179182
colSpan: number | undefined;
@@ -231,8 +234,10 @@ export type CellMouseEventHandler<R, SR> = Maybe<
231234
(args: CellMouseArgs<NoInfer<R>, NoInfer<SR>>, event: CellMouseEvent) => void
232235
>;
233236

234-
export interface BaseRenderRowProps<TRow, TSummaryRow = unknown>
235-
extends BaseCellRendererProps<TRow, TSummaryRow> {
237+
export interface BaseRenderRowProps<TRow, TSummaryRow = unknown> extends BaseCellRendererProps<
238+
TRow,
239+
TSummaryRow
240+
> {
236241
viewportColumns: readonly CalculatedColumn<TRow, TSummaryRow>[];
237242
rowIdx: number;
238243
selectedCellIdx: number | undefined;
@@ -241,8 +246,10 @@ export interface BaseRenderRowProps<TRow, TSummaryRow = unknown>
241246
gridRowStart: number;
242247
}
243248

244-
export interface RenderRowProps<TRow, TSummaryRow = unknown>
245-
extends BaseRenderRowProps<TRow, TSummaryRow> {
249+
export interface RenderRowProps<TRow, TSummaryRow = unknown> extends BaseRenderRowProps<
250+
TRow,
251+
TSummaryRow
252+
> {
246253
row: TRow;
247254
lastFrozenColumnIndex: number;
248255
draggedOverCellIdx: number | undefined;
@@ -319,11 +326,10 @@ export interface RenderSortPriorityProps {
319326

320327
export interface RenderSortStatusProps extends RenderSortIconProps, RenderSortPriorityProps {}
321328

322-
export interface RenderCheckboxProps
323-
extends Pick<
324-
React.ComponentProps<'input'>,
325-
'aria-label' | 'aria-labelledby' | 'checked' | 'tabIndex' | 'disabled'
326-
> {
329+
export interface RenderCheckboxProps extends Pick<
330+
React.ComponentProps<'input'>,
331+
'aria-label' | 'aria-labelledby' | 'checked' | 'tabIndex' | 'disabled'
332+
> {
327333
indeterminate?: boolean | undefined;
328334
onChange: (checked: boolean, shift: boolean) => void;
329335
}

‎test/browser/column/key.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ test('key is escaped in query selectors', () => {
1111

1212
expect(async () => {
1313
await setup({ columns, rows: [] });
14-
}).not.toThrow();
14+
}).not.toThrowError();
1515
});

‎test/browser/column/renderEditCell.test.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,8 @@ describe('Editor', () => {
337337
});
338338

339339
interface EditorTestProps
340-
extends Pick<Column<Row>, 'editorOptions' | 'editable'>,
340+
extends
341+
Pick<Column<Row>, 'editorOptions' | 'editable'>,
341342
Pick<DataGridProps<Row>, 'onCellKeyDown'> {
342343
onSave?: (rows: readonly Row[]) => void;
343344
gridRows?: readonly Row[];

0 commit comments

Comments
 (0)