geyser: add connection slot lag metric #508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvboudre
requested changes
Jun 10, 2025
| @@ -1089,7 +1106,7 @@ impl GrpcService { | |||
|
|
|||
| #[tonic::async_trait] | |||
| impl Geyser for GrpcService { | |||
| type SubscribeStream = ReceiverStream<TonicResult<FilteredUpdate>>; | |||
| type SubscribeStream = ReceiverStream; | |||
There was a problem hiding this comment.
We should use BoxStream<'static, TonicResult<FilteredUpdated>> instead
Comment on lines
+1322
to
+1360
| pub struct ReceiverStream { | ||
| rx: mpsc::Receiver<TonicResult<FilteredUpdate>>, | ||
| metric_connection_slot_lag: bool, | ||
| max_slot: Slot, | ||
| } | ||
|
|
||
| impl ReceiverStream { | ||
| const fn new( | ||
| rx: mpsc::Receiver<TonicResult<FilteredUpdate>>, | ||
| metric_connection_slot_lag: bool, | ||
| ) -> Self { | ||
| Self { | ||
| rx, | ||
| metric_connection_slot_lag, | ||
| max_slot: 0, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl Stream for ReceiverStream { | ||
| type Item = TonicResult<FilteredUpdate>; | ||
|
|
||
| fn poll_next(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> { | ||
| let value = futures::ready!(self.rx.poll_recv(cx)); | ||
| if self.metric_connection_slot_lag { | ||
| if let Some(slot) = value | ||
| .as_ref() | ||
| .and_then(|item| item.as_ref().map(|item| item.message.get_slot()).ok()) | ||
| .flatten() | ||
| { | ||
| if slot > self.max_slot { | ||
| self.max_slot = slot; | ||
| metrics::connections_slot_lag_observe(slot); | ||
| } | ||
| } | ||
| } | ||
| Poll::Ready(value) | ||
| } | ||
| } |
There was a problem hiding this comment.
We should use boxed the tokio stream and use map instead of implementing our own Stream trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.