make solana-transaction-status optional in yellowstone-grpc-proto #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
transaction-status-optional
branch
from
46fa299 to
a8e5c09
Compare
|
We already need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solana-transaction-status is a really annoying crate because it brings in spl-token-2022 and other crap. It also just re-exports a bunch of types from solana-transaction-status-client-types, which is more lightweight. There are only three functions that need solana-transaction-status instead of solana-transaction-status-client-types, so this PR puts those functions behind a
transaction-statusfeature