Use the OpenSSL EVP_Digest*() functions #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use the deprecated MD5_*() and SHA256_*() functions, but the generalized ones instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for writing and maintaining libdrpm!
What do you think about this change (that I am about to add to the Debian package of libdrpm), prompted by the fact that OpenSSL 3.x declares the
MD5_*()andSHA256_*()functions (among others) deprecated? TheEVP_Digest*()ones have been around since at least OpenSSL 1.1.x, and they seem to do the job, although the allocation and clean-up of the context structure does add some code.Thanks again, and keep up the great work!
G'luck,
Peter