PGP: fix: Support importing binary public keys in librpm backend, add unit tests #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `lr_gpg_import_key*` functions in the GpgMe backend support the import of binary public keys. The patch adds support for importing binary public keys to a backend that uses the librpm API. Thus eliminating the regression.
Signature "repod.xml_bad.asc" was in binary format. Therefore, the file extension was changed to ".sig". Files in ASCII Armored format have were renamed to have an ".asc" extension.
jan-kolarik
approved these changes
Oct 5, 2023
|
Thanks! |
jan-kolarik
merged commit f097eef
into
rpm-software-management:master
5 of 6 checks passed
|
@jan-kolarik Can we get this backported to Fedora and into F39 before the release? |
Oh, sure. I was checking the upstream components more than a week ago last time, and I see that particularly for librepo, it's the right time to make a new release. Thanks for the bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lr_gpg_import_key*functions in the GpgMe backend support the import of binary public keys.The patch adds support for importing binary public keys to a backend that uses the librpm API. Thus eliminating the regression.
The PR also adds unit tests for importing binary public keys.