Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase checksum buffer to 128kb, improving download performance. #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase checksum buffer to 128kb, improving download performance. #295

wants to merge 1 commit into from

Commits on Feb 9, 2024

  1. Increase checksum buffer to 128kb 

    Reading 2kb at a time to compute the checksum limits network throughput.
Bumping up to 128kb seems to give a good balance of memory usage and
performance.

Benchmarks done on a m5n.16xlarge EC2 instance doing a reposync on the
Amazon Linux 2023 x86-64 repositories showed that this change, when
combined with the (smaller) benefits of my avoiding libc IO patch,
reduce system CPU time by another half second, and cut a further 3
seconds off total time:

102s (original) -> 99 (no libc buffered io) -> 95s (this patch)
    @stewartsmith
    stewartsmith committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    89e0522 View commit details
    Browse the repository at this point in the history