Add a private dependency on zck to librepo.pc if zchunk support is enabled #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
ppisar
force-pushed
the
zchunk_in_pkgconfig
branch
from
bbc4a56
to
38efbf9
Compare
ppisar
force-pushed
the
zchunk_in_pkgconfig
branch
from
38efbf9
to
eb6e6e6
Compare
ppisar
changed the title
|
I found a proper fix. pkgconf supports this kind of header-only dependency by adding it to Requires.private. |
ppisar
changed the title
…abled
If librepo is built with zchunk support, zchunk's zck.h header file is
included from librepo public header files, thus applications building
against librepo needs zchunk header files available at build time.
Those who only use pkg-config for tracking dependencies, reported
build failures:
/usr/include/librepo/downloadtarget.h:27:10: fatal error: zck.h: No such file or directory
This patch adds the dependency on zck to librepo.pc.
It enhances Requires.private instead of Requires to prevent from
contaminating "pkgconf --libs librepo" with -lzck. Contrary, "pkgconf
--cflags librepo" correctly appends include path to zck header files.
The dependency on zck.pc is only checked and enforced with "pkgconf
--cflags librepo" invocation. This behaviour is a feature. See
<pkgconf/pkgconf#352> and
<pkgconf/pkgconf#300>.
Fixes: rpm-software-management#305
ppisar
force-pushed
the
zchunk_in_pkgconfig
branch
from
eb6e6e6
to
145f3c9
Compare
|
That PR of course is wrong because 'zck` dependency is not used only on static linking. |
|
That PR is good because "pkfconf --cflags" reports an error if zck is not installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a private dependency on zck to librepo.pc if zchunk support is enabled
If librepo is built with zchunk support, zchunk's zck.h header file is
included from librepo public header files, thus applications building
against librepo needs zchunk header files available at build time.
Those who only use pkg-config for tracking dependencies, reported
build failures:
This patch adds the dependency on zck to librepo.pc.
It enhances Requires.private instead of Requires to prevent from
contaminating "pkgconf --libs librepo" with -lzck. Contrary, "pkgconf
--cflags librepo" correctly appends include path to zck header files.
The dependency on zck.pc is only checked and enforced with "pkgconf
--cflags librepo" invocation. This behaviour is a feature. See
pkgconf/pkgconf#352 and
pkgconf/pkgconf#300.
Fixes: #305