Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken spec. #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix broken spec. #134

wants to merge 1 commit into from

Conversation

timdiggins
Copy link

Was embedding tmpdir (a randomly generated folder on some machines) twice, which then didn't exist:

  1) SeedDump.dump with file option should dump the models to the specified file
     Got 0 failures and 2 other errors:

     1.1) Failure/Error: @filename = Tempfile.new(File.join(Dir.tmpdir, 'foo'), nil)
          
          Errno::ENOENT:
            No such file or directory @ rb_sysopen - /var/folders/yh/RANDOMNESS/T/var/folders/yh/RANDOMNESS/T/foo20180522-6029-7061cr
          # ./spec/dump_methods_spec.rb:33:in `new'
          # ./spec/dump_methods_spec.rb:33:in `block (4 levels) in <top (required)>'

     1.2) Failure/Error: File.unlink(@filename)
          
          TypeError:
            no implicit conversion of nil into String
          # ./spec/dump_methods_spec.rb:37:in `unlink'
          # ./spec/dump_methods_spec.rb:37:in `block (4 levels) in <top (required)>'

Was embedding tmpdir twice, which then didn't exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant