Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for HashWithIndifferentAccess field #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edg3r
Copy link

@edg3r edg3r commented Feb 2, 2015

If model had serialize :field, HashWithIndifferentAccess
it was returned as a Hash, thus breaking model creation from seed dump

previously field was returned as a Hash, thus breaking model creation from seed dump
@rroblak
Copy link
Owner

rroblak commented Apr 14, 2015

@edg3r Thanks for the PR!

Ideally I'd like for SeedDump#value_to_s to not have a special return statement for ActiveSupport::HashWithIndifferentAccess. Would you mind modifying your PR so that SeedDump#value_to_s just consists of a single case...when...end block, with all of the existing when articles (e.g. BigDecimal, Range, else) calling #inspect on their return values?

Also, before merging I'd like for it to be covered by one or more specs. Feel free to update your PR with specs covering the functionality.

Feel free to do none, some, or all of my suggestions. I'll do whatever you don't do before merging the PR, though I'm pretty busy right now so no guarantees on when that will be.

@edg3r
Copy link
Author

edg3r commented Apr 16, 2015

@rroblak Hey! I'm a little short on time too these days. But I'll try and add at least some of your suggestions in the near future

@kofronpi kofronpi added this to the 3.3.0 milestone May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants