Vala rewrite and release 2.7.0 #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also lift the limit on words in the PWL being at most BUFSIZ bytes long. This seems a fairly arbitrary limit, some technical words can be 200k letters long, and it’s not obvious what a better limit is, or that having an indefinite limit will actually be a problem.
Split lib.c into a set of Vala files.
* Tweak the semantics of dictionaries: it’s now possible to have multiple
dictionaries in the same broker for the same language tag. Before, a
second request for the same tag would return an existing dictionary.
Remove the relevant tests.
* Adjust provider API:
+ EnchantProvider is now a reference-counted Vala class. It should be
created with enchant_provider_new() and freed with
enchant_provider_free().
+ EnchantDict is now a reference-counted Vala class. Providers call
enchant_broker_new_dict() to create a dictionary, and may call
enchant_broker_free_dict() to free it; otherwise, it will be freed when
the broker is.
+ Make the dispose method of providers optional, as not all providers now
require one.
+ Rename the private structs from str_enchant_foo to _EnchantFoo, to match
Vala names.
* Build system tweaks:
+ Assume we have LC_MESSAGES, as GLib assumes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly contains a rewrite of the main library into Vala. See NEWS for full details.