Delay creation of EnchantDict to avoid partial initialization in AppleSpell provider#399
Closed
nossralf wants to merge 9 commits intorrthomas:masterfrom
Closed
Conversation
Use GLib’s option parsing for enchant but not enchant-lsmod (see rrthomas#378). This commit also includes updates to the GLib VAPI. Remove enchant_get_user_language from the public API, as it’s now trivial, and was probably not applicable to all applications anyway.
But don’t make it a recursive target, so we still get an overall count when running it at the top level.
To properly destruct an EnchantDict, its session field must be non-null since the destructor assumes a session has been associated with the object. This association happens in EnchantBroker when a provider upon request finds a valid dictionary and in doing so creates an EnchantDict object which is returned to the broker. In the AppleSpell provider, the EnchantDict was created regardless of whether the provider would be able to find a valid dictionary or not. If it did not find a valid dictionary, it would erroneously free the EnchantDict object and return null, despite the leaving the EnchantDict in the broker's set of dictionaries. This commit fixes the issue by moving the creation of the EnchantDict to occur after successfully finding a valid dictionary. Fixes rrthomas#391
nossralf
changed the title
Owner
|
Thanks very much for looking into this, and I'll review ASAP. |
rrthomas
force-pushed
the
master
branch
2 times, most recently
from
d203155 to
34de772
Compare
Owner
|
I have applied your patch (I rewrote history so the PR now has conflicts, but the patch is fine). Many thanks. I aim to make a new release soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To properly destruct an EnchantDict, its session field must be non-null since the destructor assumes a session has been associated with the object. This association happens in EnchantBroker when a provider upon request finds a valid dictionary and in doing so creates an EnchantDict object which is returned to the broker.
In the AppleSpell provider, the EnchantDict was created regardless of whether the provider would be able to find a valid dictionary or not. If it did not find a valid dictionary, it would erroneously free the EnchantDict object and return null, despite the leaving the EnchantDict in the broker's set of dictionaries.
This commit fixes the issue by moving the creation of the EnchantDict to occur after successfully finding a valid dictionary.
Fixes #391