Skip paper name detection for Android #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report. I'd rather use feature detection than simply make this Android-specific. I've pushed a fix to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android's bionic (
langinfo.h) never define or provide_NL_PAPER_WIDTHand_NL_PAPER_HEIGHTat all, so there is no such thingnl_langinfo(_NL_PAPER_WIDTH). Libreoffice'spaper.cxxbasically skip that part of locale paper size detection with&& !defined(ANDROID). See:https://github.com/LibreOffice/core/blob/7db1150b2c4a9adb993084d2dceedb450781b1dc/i18nutil/source/utility/paper.cxx#L308-L317
Note; libreoffice's
ANDROIDis probably configured by their makefile and will not work for your projectlibpaper, so I patch that to!defined(__ANDROID__)and it is a correct one (https://android.googlesource.com/platform/bionic/+/HEAD/docs/defines.md)It is recognized by Termux devs (resembling a linux distro on Android) at termux/termux-packages#21510