-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single style capture #1437
Single style capture #1437
Conversation
🦋 Changeset detectedLatest commit: 58bfecc The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3ea2885
to
1d59339
Compare
fa37bfa
to
0c875be
Compare
47f542b
to
6210356
Compare
f5f1bde
to
ee6c028
Compare
0c7403e
to
1b71bc3
Compare
58b031d
to
746dfbd
Compare
2fcf2fb
to
02f4fcb
Compare
54fc502
to
938aeea
Compare
938aeea
to
007612d
Compare
d98422a
to
416a8b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this Eoghan!
bd99f6f
to
5cc3ee3
Compare
… replay them correctly' test into a dedicated 'backwards compatibility' version to ensure older recordings can still be replayed correctly even when the duplicate data generated is fixed in rrweb-io#1437
4b1623c
to
75808d8
Compare
…t getting rebuilt with `adaptCssForReplay`
…ext content, but I was mistaken; adding as I think it still has value in terms of regression
…te content in mutation between _cssText and a text node
…de after a mutation as it's textContent wasn't getting a serialized id
…ple child nodes Add a new integration test to verify that style mutations with multiple child nodes are recorded and replayed correctly. The test sets the color of two div elements using CSS and verifies that the color is applied correctly after replaying the recorded events.
- Don't record css content twice when a <style> element is added in a mutation - Fix case where we wouldn't have been able to mutate a <style> text node after a mutation as it's textContent wasn't getting a serialized id
…y style mutations' covers more ground. Could probably emphasize that these 2 are related to `insertRule` i.e. programmatic mutations as opposed to text mutations
The prior 'dynamic stylesheet' route is now the main route for serializing a stylesheet; dynamic stylesheet were missed out in rrweb-io#1533 but are caught in this PR by the tests added in that PR as the stylesheet handling is simplified/centralised
…ns entire css text when there are too few child nodes' passes Co-authored-by: Justin Halsall <[email protected]>
Co-authored-by: Justin Halsall <[email protected]>
Co-authored-by: Justin Halsall <[email protected]>
Co-authored-by: Justin Halsall <[email protected]>
3eb869b
to
9770a16
Compare
…sString` function (thanks Justin). Add test to show when this matters
i don't have an exact page to reproduce this problem, but i find that
now fails to replay despite being "valid" on the browser |
here's a repro - run this on any page with rrweb recording:
|
Prep PR for async <style> serialization via assets: refactor stringifyStylesheet to happen in a single place during initial snapshot.