Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple puncts in a row in NodeName #42

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

PizzasBear
Copy link

Removed NodeNameFragment::peek_any, since this function should always return true because it can be NodeNameFragment::Empty. This allows NodeNameFragment::Empty to actually separate puncts which allows multiple puncts in a row to be parsed as NodeName::Punctuated

@vldm
Copy link
Collaborator

vldm commented Oct 31, 2023

@PizzasBear Hi, Thanks for contribution, could you please add a test for that case?

@PizzasBear
Copy link
Author

I've added the test

@codecov-commenter
Copy link

Codecov Report

Merging #42 (fd3630c) into main (12753af) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head fd3630c differs from pull request most recent head ba78bbb. Consider uploading reports for the commit ba78bbb to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   76.86%   76.80%   -0.07%     
==========================================
  Files          12       12              
  Lines         752      750       -2     
==========================================
- Hits          578      576       -2     
  Misses        174      174              
Files Coverage Δ
src/node/node_name.rs 75.00% <100.00%> (+0.40%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vldm vldm added this pull request to the merge queue Nov 1, 2023
Merged via the queue into rs-tml:main with commit 8f8f199 Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants