Skip to content

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jun 25, 2025

Python 3.14 beta has been released and the release manager (👋 hi! that's me!) said:

We strongly encourage maintainers of third-party Python projects to test with 3.14 during the beta phase and report issues found to the Python bug tracker as soon as possible. While the release is planned to be feature-complete entering the beta phase, it is possible that features may be modified or, in rare cases, deleted up until the start of the release candidate phase (Tuesday 2025-07-22). Our goal is to have no ABI changes after beta 4 and as few code changes as possible after the first release candidate. To achieve that, it will be extremely important to get as much exposure for 3.14 as possible during the beta phase.

@rsalmei
Copy link
Owner

rsalmei commented Jun 25, 2025

Thanks @hugovk. Let's add 3.14 indeed!

I'm a little confused about those "pull_request, workflow_dispatch" triggers. Pushing's always worked great for me, so every push triggers the workflows.
It seems unnecessary to include all those activity triggers for pull requests and manual triggers. What makes them useful, in your view?

@hugovk
Copy link
Contributor Author

hugovk commented Jun 26, 2025

Sure, pull_request is so that PRs created by others are tested on the CI.

This means you have merge them with the confidence that the CI has passed and that they've not broken any existing test.

For example, you can see that this PR has run on the CI and is green 🎉, but this other PR (#269) has not -- has it broken the CI? Maybe it uses new syntax and fails on Python 3.9? Who knows 🤷 -- the only way to be sure is to merge the PR and find out. It's a bit late then, and it's much better to know before merge so the PR can be fixed, and main can be always kept in a releasable state.


workflow_dispatch is a nice little extra: it will add a button to the UI at https://github.com/rsalmei/alive-progress/actions/workflows/main.yml

Here's screenshots from another repo that has it:

image image

It lets us trigger a build on any branch on demand (it's a little odd that GitHub doesn't enable it by default). This isn't needed very often, but occasionally it can be useful. For example, maybe a PR fails in an odd way, and I might want to trigger a main build to see if the same failure happens on main -- maybe there's something wrong on GitHub's side, or with a dependency or something.

@rsalmei
Copy link
Owner

rsalmei commented Jul 18, 2025

Hey @hugovk, thank you!
It still seems to me that these new triggers aren’t particularly useful, but there’s no reason to leave them out.
I'm merging it now.

@rsalmei rsalmei merged commit 00fe1c6 into rsalmei:main Jul 18, 2025
6 checks passed
@hugovk hugovk deleted the add-3.14 branch July 19, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants